From owner-freebsd-current@FreeBSD.ORG Sat Dec 11 14:30:28 2004 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id C75DD16A4CE; Sat, 11 Dec 2004 14:30:28 +0000 (GMT) Received: from postfix4-2.free.fr (postfix4-2.free.fr [213.228.0.176]) by mx1.FreeBSD.org (Postfix) with ESMTP id 644C543D48; Sat, 11 Dec 2004 14:30:28 +0000 (GMT) (envelope-from tataz@tataz.chchile.org) Received: from tatooine.tataz.chchile.org (unknown [82.233.239.98]) by postfix4-2.free.fr (Postfix) with ESMTP id 3B13125593B; Sat, 11 Dec 2004 15:30:26 +0100 (CET) Received: by tatooine.tataz.chchile.org (Postfix, from userid 1000) id 5FCF9412C; Sat, 11 Dec 2004 15:28:26 +0100 (CET) Date: Sat, 11 Dec 2004 15:28:25 +0100 From: Jeremie Le Hen To: Shunsuke SHINOMIYA Message-ID: <20041211142825.GB65171@obiwan.tataz.chchile.org> References: <20041210113318.BBF3.SHINO@fornext.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20041210113318.BBF3.SHINO@fornext.org> User-Agent: Mutt/1.5.6i cc: freebsd-stable@freebsd.org cc: freebsd-current@freebsd.org cc: Jeremie Le Hen Subject: Re: if_em int_throttle_ceil patch X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Dec 2004 14:30:28 -0000 On Fri, Dec 10, 2004 at 12:00:21PM +0900, Shunsuke SHINOMIYA wrote: > The previous patch to change if_em's int_throttle_ceil into > sysctl-able cause a kernel panic. If you set em's int_throttle_ceil=0 > and then reconfigure the em, it cause a diveded by zero panic. > > This patch for original if_em.[ch] which is attached to this mail is > corrected this problem. Great work Shunsuke, thank you ! Any chance to get this patch reviewed and commited ? Although Bjoern Zeeb proposed to use a global way to control interrupt moderation among network drivers, there was no proposition to unify it. It would be a pity if this patch gets lost in the archives without being either commited or submited as a PR. Regards, -- Jeremie Le Hen jeremie@le-hen.org