From owner-svn-src-head@FreeBSD.ORG Thu Jun 11 13:30:14 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 9B5454A0; Thu, 11 Jun 2015 13:30:14 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: from mail-wi0-x22b.google.com (mail-wi0-x22b.google.com [IPv6:2a00:1450:400c:c05::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 355621C20; Thu, 11 Jun 2015 13:30:14 +0000 (UTC) (envelope-from baptiste.daroussin@gmail.com) Received: by wibut5 with SMTP id ut5so74728023wib.1; Thu, 11 Jun 2015 06:30:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=gzWI2j5AvbKrvO9a1Hh7p/xJ3rx1HhD5KwQSLxP+xxM=; b=fWrkV+9nZZbprcVnt+gC34KFiBe9xRT2vpjor4rdwVtnamjxC+nTb3zBNkY8JtOoRC IIHyaExzvZ45g0hfJ2I1iwxnoSwIVudoipIiX68+xo3Hd6t281mKKIt3v3S74VxkQam2 FGrr1m7FfFH/pVDIKR87/WykdiaEo/1FWge/JYBnIfK4eMPGDzZem/ConeGkMXtIJeKu zXITeEkykzcGx2OhACWu8v/DAhKWIQvo9IBH2H4v89rFoT5B9tXMP9lov19dYt0qFCIN CtVXZI4PPWMEBdpnuA+oYQGI6qNI86ybLMs2TKNkePlv1P4/7t1MBeinabPt99w9aqIE 0Gug== X-Received: by 10.180.106.195 with SMTP id gw3mr5971337wib.25.1434029412644; Thu, 11 Jun 2015 06:30:12 -0700 (PDT) Received: from ivaldir.etoilebsd.net ([2001:41d0:8:db4c::1]) by mx.google.com with ESMTPSA id g15sm1667452wiv.22.2015.06.11.06.30.11 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Jun 2015 06:30:11 -0700 (PDT) Sender: Baptiste Daroussin Date: Thu, 11 Jun 2015 15:30:09 +0200 From: Baptiste Daroussin To: Jung-uk Kim Cc: Xin LI , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r284237 - in head: contrib/file contrib/file/doc contrib/file/magic contrib/file/magic/Magdir contrib/file/python contrib/file/src contrib/file/tests lib/libmagic Message-ID: <20150611133009.GB7560@ivaldir.etoilebsd.net> References: <201506101922.t5AJMf27015406@svn.freebsd.org> <557926DC.9090008@FreeBSD.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="A6N2fC+uXW/VQSAv" Content-Disposition: inline In-Reply-To: <557926DC.9090008@FreeBSD.org> User-Agent: Mutt/1.5.23 (2014-03-12) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Jun 2015 13:30:14 -0000 --A6N2fC+uXW/VQSAv Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Jun 11, 2015 at 02:12:44AM -0400, Jung-uk Kim wrote: > On 06/10/2015 15:22, Xin LI wrote: > > Author: delphij Date: Wed Jun 10 19:22:41 2015 New Revision: > > 284237 URL: https://svnweb.freebsd.org/changeset/base/284237 > >=20 > > Log: MFV r284234: > >=20 > > Update file to 5.23. > ... >=20 > I found a serious regression with this version, i.e., some long > options does not work as intended. --extension works like > --mime-type, --mime-type works like --mime-encoding, etc. When the > author added -Z/--uncompress-noreport, forgot to update those offsets, > it seems. My patch is available from here: >=20 > https://github.com/file/file/commit/bda61b688a#commitcomment-11626945 >=20 > In fact, this is very critical for us because LIB_DEPENDS for ports > does not work any more because it uses --mime-type to verify its type. >=20 > https://svnweb.freebsd.org/ports/head/Mk/Scripts/find-lib.sh?revision=3D3= 83711&view=3Dmarkup#l20 >=20 Can you just commit your patch asap directly in the contrib directory so the next build of packages on head will not be broken? Best regards, Bapt --A6N2fC+uXW/VQSAv Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlV5jWEACgkQ8kTtMUmk6EyfJQCggD3irdxxwRUsmXbK1EmC6dbU LBUAni8PwIV/uxcaSCB5ic7u0UCVMUs5 =Rq5H -----END PGP SIGNATURE----- --A6N2fC+uXW/VQSAv--