From owner-svn-src-head@FreeBSD.ORG Fri Jun 29 17:36:01 2012 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9257B1065672 for ; Fri, 29 Jun 2012 17:36:01 +0000 (UTC) (envelope-from pfg@freebsd.org) Received: from nm29-vm0.bullet.mail.sp2.yahoo.com (nm29-vm0.bullet.mail.sp2.yahoo.com [98.139.91.236]) by mx1.freebsd.org (Postfix) with SMTP id 62EDD8FC18 for ; Fri, 29 Jun 2012 17:36:01 +0000 (UTC) Received: from [72.30.22.79] by nm29.bullet.mail.sp2.yahoo.com with NNFMP; 29 Jun 2012 17:36:01 -0000 Received: from [72.30.22.187] by tm13.bullet.mail.sp2.yahoo.com with NNFMP; 29 Jun 2012 17:36:00 -0000 Received: from [127.0.0.1] by omp1063.mail.sp2.yahoo.com with NNFMP; 29 Jun 2012 17:36:00 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 413218.63982.bm@omp1063.mail.sp2.yahoo.com Received: (qmail 71746 invoked by uid 60001); 29 Jun 2012 17:35:59 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1340991359; bh=e87NgSNbjzhVbxJKawDjb9K6C5JHE8ZQSZHA1yAqUlQ=; h=X-YMail-OSG:Received:X-RocketYMMF:X-Mailer:Message-ID:Date:From:Reply-To:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=5khTvpvb5ZNTkfUqm2WoUVei3wdOex41ABhVFG3V8fIV76CyVOWONQgrwyuATiEIm1V4CPY0pK+7GiIACgmUma354r6zN1QOptEegnfWQAZ5sM5iBNWp/1V3JDr/TPJcPqp6UVmPYQPVOCN9IX5ZmdffwiS8ki7CMKnYvJgfSb0= X-YMail-OSG: f_fwSQUVM1nrp5k.49GZ9aOk0l6ag6GZeeyfemQHU5bWCPA szul7gdx2H3CVyFFh8l8S423LaK7MoeM.m2vKkFOCelBnzCbaQT0mBRt0rmQ 6Vp7j3KDl2SYXfXmu33UGKU7cdGZI.WYsRDcDE7UYXLp9po8HYp8A5YS8mRR n6mKd2RRu8du3tWTRunYq3VnsRnBSDpLFM1ThDDmKg6_wL7_QNwXooTdddjY SS_.oxyUEobXd51.VVzVq04aeOuZ72zns_UrLCzcMyazpjTIV6djBeFnM7wg b5WoP_HgQI2g4AtLPhFb5gMBnUjb1s6gKg23E8T4nleLDxc_aj_cLMQ_RexP c9y7ZLD_7V_HPpcQRcaG9QYgU1GFuifcLcj_Rt8oKUPMSdXl.l5_TKH_XidQ 29bQuy4OVRv5f6iRZbJqkptoi7M.hCgUxVfAnNmqANzLj4XzUzphYkMTH9nC gfVZ4RpZxSPSmYbmLeBaSOVmEvYR4OInHhnEYqFvo3j26YptenzVkFyiYNf9 23qjLG7N_iuDsNA8IXRrroOz29Zg40MKZA84- Received: from [200.118.157.7] by web113502.mail.gq1.yahoo.com via HTTP; Fri, 29 Jun 2012 10:35:59 PDT X-RocketYMMF: giffunip X-Mailer: YahooMailClassic/15.0.8 YahooMailWebService/0.8.118.349524 Message-ID: <1340991359.60778.YahooMailClassic@web113502.mail.gq1.yahoo.com> Date: Fri, 29 Jun 2012 10:35:59 -0700 (PDT) From: Pedro Giffuni To: obrien@FreeBSD.org In-Reply-To: <20120629152109.GA70522@dragon.NUXI.org> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r237624 - in head: cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llquantize cddl/contrib/opensolaris/lib/libdtrace/common sys/cddl/contrib/opensolaris/uts/common/dtrace sys/cddl/c... X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pfg@freebsd.org List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jun 2012 17:36:01 -0000 (Sorry for top-posting]=0A=0AActually ...=0A=0ADavid pointed out a fundamen= tal flaw on my part.=0A=0AThese are new files under a non-BSD license. Even= when=0Athey are only scripts used for testing I shouldn't have=0Abrought t= hem in without -core approval.=0A=0AI will delete them right away and core = shall decide=0Aafterwards if and how they can be brought in.=0A=0APedro.=0A= =0A=0A--- Ven 29/6/12, David O'Brien ha scritto:=0A=0A= > Da: David O'Brien =0A> Oggetto: Re: svn commit: r2376= 24 - in head: cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llquantiz= e cddl/contrib/opensolaris/lib/libdtrace/common sys/cddl/contrib/opensolari= s/uts/common/dtrace sys/cddl/c...=0A> A: "Pedro F. Giffuni" =0A> Cc: src-committers@FreeBSD.org, svn-src-all@FreeBSD.org, svn-src-hea= d@FreeBSD.org=0A> Data: Venerd=EC 29 giugno 2012, 10:21=0A> On Wed, Jun 27,= 2012 at 04:39:30AM=0A> +0000, Pedro F. Giffuni wrote:=0A> > Log:=0A> >=A0= =A0=A0Bring llquantize support into Dtrace.=0A> >=A0=A0=A0Bryan Cantrill im= plemented the=0A> equivalent of semi-log graph=0A> >=A0=A0=A0paper for Dtra= ce so llquantize will=0A> use one logarithmic and=0A> >=A0=A0=A0one linear = scale.=0A> ...=0A> >=A0=A0=A0Obtained from:=A0=A0=A0=0A> Illumos=0A> ...=0A= > > Added:=0A> head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/common/llq= uantize/err.D_LLQUANT_FACTOREVEN.nodivide.d=0A> >=0A> =3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=0A> > --- /= dev/null=A0=A0=A0 00:00:00=0A> 1970=A0=A0=A0 (empty, because file is newly = added)=0A> > +++=0A> head/cddl/contrib/opensolaris/cmd/dtrace/test/tst/comm= on/llquantize/err.D_LLQUANT_FACTOREVEN.nodivide.d=A0=A0=A0=0A> Wed Jun 27 0= 4:39:30 2012=A0=A0=A0 (r237624)=0A> > @@ -0,0 +1,29 @@=0A> > +/*=0A> > + * = CDDL HEADER START=0A> > + *=0A> > + * The contents of this file are subject= to the terms=0A> of the=0A> > + * Common Development and Distribution Lice= nse (the=0A> "License").=0A> > + * You may not use this file except in comp= liance with=0A> the License.=0A> ...=0A> > +/*=0A> > + * Copyright (c) 2011= , Joyent, Inc. All rights=0A> reserved.=0A> > + */=0A> =0A> Pedro,=0A> It l= ooks like you simply 'svn add'ed this file, rather than=0A> importing it=0A= > into '^/vendor/opensolaris/dist'.=A0 Please correct me if=0A> I am wrong.= =0A> =0A> We've become rather sloppy in the past 1-2 years in our=0A> handl= ing of=0A> 3rd-party externally developed code.=A0 Something we need=0A> to= return to=0A> our older ways good ways of handling.=0A> =0A> This is somet= hing that is especially important with GPL,=0A> CDDL, and=0A> similar licen= ses.=0A> =0A> Commercial entities that base products on FreeBSD have to=0A>= worry about=0A> code provenance for various intellectual property legal=0A= > reasons and we=0A> muddy the waters when we make it harder to track who a= nd=0A> where code came=0A> from.=0A> [Please see http://www.osgeo.org/incub= ator/process/codereview.html=0A> &=0A> http://wiki.osgeo.org/wiki/Code_Prov= enance_Review to=0A> better understand=0A> this issue.]=0A> =0A> Not follow= ing our established procedure also means that the=0A> average=0A> developer= (committer) and commercial consumer will have their=0A> expectations=0A> fa= il.=A0 One expects to be able to find the stock vendor=0A> sources in=0A> s= sh://svn.freebsd.org/base/vendor/ and to be able to find=0A> FreeBSD local= =0A> changes to the sources thru 'svn diff' against=0A> 'ssh://svn.freebsd.= org/base/head'.=0A> =0A> Please correct this by properly importing the sour= ces, 'svn=0A> delete'ing=0A> the files you 'svn add'ed, and do an 'svn copy= ' of the new=0A> files.=0A> =0A> thanks,=0A> -- =0A> -- David=A0 (obrien@Fr= eeBSD.org)=0A>