From owner-freebsd-arm@FreeBSD.ORG Wed Jan 21 15:35:47 2009 Return-Path: Delivered-To: freebsd-arm@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 05D581065672; Wed, 21 Jan 2009 15:35:47 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from harmony.bsdimp.com (bsdimp.com [199.45.160.85]) by mx1.freebsd.org (Postfix) with ESMTP id BA19D8FC12; Wed, 21 Jan 2009 15:35:46 +0000 (UTC) (envelope-from imp@bsdimp.com) Received: from localhost (localhost [127.0.0.1]) by harmony.bsdimp.com (8.14.2/8.14.1) with ESMTP id n0LFY0rP024798; Wed, 21 Jan 2009 08:34:00 -0700 (MST) (envelope-from imp@bsdimp.com) Date: Wed, 21 Jan 2009 08:34:38 -0700 (MST) Message-Id: <20090121.083438.1081366624.imp@bsdimp.com> To: mav@FreeBSD.org From: "M. Warner Losh" In-Reply-To: <4976E2C2.4090002@FreeBSD.org> References: <49762CEF.1000405@FreeBSD.org> <49762EC9.1010006@FreeBSD.org> <4976E2C2.4090002@FreeBSD.org> X-Mailer: Mew version 5.2 on Emacs 21.3 / Mule 5.0 (SAKAKI) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: freebsd-arm@FreeBSD.org Subject: Re: Mount root from SD card? X-BeenThere: freebsd-arm@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting FreeBSD to the StrongARM Processor List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jan 2009 15:35:47 -0000 In message: <4976E2C2.4090002@FreeBSD.org> Alexander Motin writes: : Alexander Motin wrote: : > Alexander Motin wrote: : >> M. Warner Losh wrote: : >>> In message: <20090120.122312.1543793985.imp@bsdimp.com> : >>> "M. Warner Losh" writes: : >>> : : IMHO it is incorrect to disable 4bit mode on that stage, it is : >>> too late : : there. It should be done at controller capabilities : >>> announcement stage. : : If you are not objecting, I would remove that : >>> wire4 variable. : >>> : : I am objecting. The code is there so that the rest of the driver : >>> does : >>> : the right thing when doing 4-bit. It needs to be a capability too. : >>> : : However, before we go monkeying with this, we need to find the : >>> : underlying bug. : >>> : >>> I've got the following patch, untested, that I think does what I think : >>> needs to be done. Not sure about the return value from update_ios... : : I would prefer attached variant. It will also disable 4-bit support by : default, but will make it properly. How do you plan to control that : wire4 variable? With device.hints? It is part of the board-variant work that I have in flight. I'm not 100% sure the exact mechanism, but the meta-data about how the device is wired will be provided by "the parent device" in some way. I'm still working out the details. Warner