From owner-svn-src-all@FreeBSD.ORG Fri Oct 24 09:52:08 2008 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 512681065670; Fri, 24 Oct 2008 09:52:08 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from mail03.syd.optusnet.com.au (mail03.syd.optusnet.com.au [211.29.132.184]) by mx1.freebsd.org (Postfix) with ESMTP id DD5F88FC36; Fri, 24 Oct 2008 09:52:07 +0000 (UTC) (envelope-from brde@optusnet.com.au) Received: from c122-106-151-199.carlnfd1.nsw.optusnet.com.au (c122-106-151-199.carlnfd1.nsw.optusnet.com.au [122.106.151.199]) by mail03.syd.optusnet.com.au (8.13.1/8.13.1) with ESMTP id m9O9pviH003253 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 24 Oct 2008 20:52:02 +1100 Date: Fri, 24 Oct 2008 20:51:57 +1100 (EST) From: Bruce Evans X-X-Sender: bde@delplex.bde.org To: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= In-Reply-To: <86ej27xgzy.fsf@ds4.des.no> Message-ID: <20081024204301.A72819@delplex.bde.org> References: <200810231553.m9NFrqQj060598@svn.freebsd.org> <20081023184621.GA32081@ws64.jh.dy.fi> <86ej27xgzy.fsf@ds4.des.no> MIME-Version: 1.0 Content-Type: MULTIPART/MIXED; BOUNDARY="0-1994515382-1224841917=:72819" Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, Jaakko Heinonen , src-committers@FreeBSD.org Subject: Re: svn commit: r184205 - in head: . share/man/man9 sys/arm/arm sys/cam/scsi sys/compat/linux sys/contrib/altq/altq sys/contrib/ipfilter/netinet sys/dev/ar sys/dev/ce sys/dev/hwpmc sys/dev/lmc sys/dev/... X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Oct 2008 09:52:08 -0000 This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --0-1994515382-1224841917=:72819 Content-Type: TEXT/PLAIN; charset=X-UNKNOWN; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE On Thu, 23 Oct 2008, [utf-8] Dag-Erling Sm=C3=B8rgrav wrote: > Jaakko Heinonen writes: >> This change introduces some bad formatting. Many statements would now >> fit to 80 columns and don't need to be wrapped. > > You're right, and I'd appreciate a patch, if you feel like it - but not > right away, as I'm about to revert the net80211 parts of the commit. > >> There are also places with unnecessary white space: > > They were already broken, and I didn't want to mix style changes with > code changes. Actually, at least the first 6 weren't broken, but were broken by mixing style changes with the code changes. The first 1 is: % Modified: head/sys/contrib/altq/altq/altq_hfsc.c % =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D % --- head/sys/contrib/altq/altq/altq_hfsc.c=09Thu Oct 23 15:44:00 2008=09(= r184204) % +++ head/sys/contrib/altq/altq/altq_hfsc.c=09Thu Oct 23 15:53:51 2008=09(= r184205) % ... % @@ -471,8 +471,7 @@ hfsc_class_create(struct hfsc_if *hif, s % #endif /* ALTQ_RED */ %=20 % =09if (rsc !=3D NULL && (rsc->m1 !=3D 0 || rsc->m2 !=3D 0)) { % -=09=09MALLOC(cl->cl_rsc, struct internal_sc *, % -=09=09 sizeof(struct internal_sc), M_DEVBUF, M_WAITOK); % +=09=09cl->cl_rsc =3D malloc(=09=09 sizeof(struct internal_sc), M_DEVB= UF, M_WAITOK); % =09=09if (cl->cl_rsc =3D=3D NULL) % =09=09=09goto err_ret; % =09=09sc2isc(rsc, cl->cl_rsc); Here the sizeof() was perfectly indented, with 2 tabs and then 4 spaces for a continuation line. A dumb sed script appears to have been run over this blindly. It duplicated the 2 tabs and 4 spaces, which would have been OK if it didn't also join the lines by removing only the newline, leaving weird whitespace after "malloc(". Bruce --0-1994515382-1224841917=:72819--