From owner-freebsd-bugs@FreeBSD.ORG Fri May 29 22:50:03 2009 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E5E341065673 for ; Fri, 29 May 2009 22:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id C23BA8FC1E for ; Fri, 29 May 2009 22:50:03 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n4TMo3oI035477 for ; Fri, 29 May 2009 22:50:03 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n4TMo3S4035476; Fri, 29 May 2009 22:50:03 GMT (envelope-from gnats) Resent-Date: Fri, 29 May 2009 22:50:03 GMT Resent-Message-Id: <200905292250.n4TMo3S4035476@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Mateusz Guzik Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 21C761065670 for ; Fri, 29 May 2009 22:48:56 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (www.freebsd.org [IPv6:2001:4f8:fff6::21]) by mx1.freebsd.org (Postfix) with ESMTP id 107008FC15 for ; Fri, 29 May 2009 22:48:56 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from www.freebsd.org (localhost [127.0.0.1]) by www.freebsd.org (8.14.3/8.14.3) with ESMTP id n4TMmtEI005296 for ; Fri, 29 May 2009 22:48:55 GMT (envelope-from nobody@www.freebsd.org) Received: (from nobody@localhost) by www.freebsd.org (8.14.3/8.14.3/Submit) id n4TMmtRN005295; Fri, 29 May 2009 22:48:55 GMT (envelope-from nobody) Message-Id: <200905292248.n4TMmtRN005295@www.freebsd.org> Date: Fri, 29 May 2009 22:48:55 GMT From: Mateusz Guzik To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: kern/135067: [patch][fib] Incorrect KASSERTs in sys/net/route.c X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 May 2009 22:50:04 -0000 >Number: 135067 >Category: kern >Synopsis: [patch][fib] Incorrect KASSERTs in sys/net/route.c >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri May 29 22:50:03 UTC 2009 >Closed-Date: >Last-Modified: >Originator: Mateusz Guzik >Release: 8.0-CURRENT >Organization: >Environment: FreeBSD eternal 8.0-CURRENT FreeBSD 8.0-CURRENT #2: Fri May 29 23:33:10 CEST 2009 f@eternal:/usr/obj/usr/src/sys/ETERNAL i386 >Description: setfib() compares like this: uap->fibnum >= rt_numfibs but KASSERT(fibnum < rt_numfibs) used in various places does not catch the case when fibnum == rt_numfibs. I believe it should be 'fibnum <= rt_numfibs' to match the check performed in setfib (and not read/write past rt_tables if fibnum == rt_numfibs == RT_MAXFIBS). >How-To-Repeat: >Fix: Patch attached with submission follows: --- route.c.orig 2009-05-02 07:02:28.000000000 +0200 +++ route.c 2009-05-30 00:23:45.000000000 +0200 @@ -297,7 +297,7 @@ int err = 0, msgtype = RTM_MISS; int needlock; - KASSERT((fibnum < rt_numfibs), ("rtalloc1_fib: bad fibnum")); + KASSERT((fibnum <= rt_numfibs), ("rtalloc1_fib: bad fibnum")); if (dst->sa_family != AF_INET) /* Only INET supports > 1 fib now */ fibnum = 0; rnh = V_rt_tables[fibnum][dst->sa_family]; @@ -936,7 +936,7 @@ struct sockaddr *ndst; #define senderr(x) { error = x ; goto bad; } - KASSERT((fibnum < rt_numfibs), ("rtrequest1_fib: bad fibnum")); + KASSERT((fibnum <= rt_numfibs), ("rtrequest1_fib: bad fibnum")); if (dst->sa_family != AF_INET) /* Only INET supports > 1 fib now */ fibnum = 0; /* @@ -1232,7 +1232,7 @@ endfib = rt_numfibs - 1; } } else { - KASSERT((fibnum < rt_numfibs), ("rtinit1: bad fibnum")); + KASSERT((fibnum <= rt_numfibs), ("rtinit1: bad fibnum")); startfib = fibnum; endfib = fibnum; } >Release-Note: >Audit-Trail: >Unformatted: