From owner-svn-src-head@FreeBSD.ORG Fri Jun 29 17:51:52 2012 Return-Path: Delivered-To: svn-src-head@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DC900106564A; Fri, 29 Jun 2012 17:51:52 +0000 (UTC) (envelope-from gnn@neville-neil.com) Received: from vps.hungerhost.com (vps.hungerhost.com [216.38.53.176]) by mx1.freebsd.org (Postfix) with ESMTP id ABFF38FC12; Fri, 29 Jun 2012 17:51:52 +0000 (UTC) Received: from [209.249.190.124] (port=59017 helo=gnnmac.hudson-trading.com) by vps.hungerhost.com with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.77) (envelope-from ) id 1SkfMG-0001Wo-C9; Fri, 29 Jun 2012 13:51:52 -0400 Mime-Version: 1.0 (Apple Message framework v1280) Content-Type: text/plain; charset=us-ascii From: George Neville-Neil In-Reply-To: <4FED5C51.9060603@FreeBSD.org> Date: Fri, 29 Jun 2012 13:51:52 -0400 Content-Transfer-Encoding: quoted-printable Message-Id: References: <201206290735.q5T7ZbSk026312@svn.freebsd.org> <4FED5C51.9060603@FreeBSD.org> To: Andriy Gapon X-Mailer: Apple Mail (2.1280) X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - vps.hungerhost.com X-AntiAbuse: Original Domain - freebsd.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - neville-neil.com Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r237748 - in head/sys/cddl/dev/dtrace: amd64 i386 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 29 Jun 2012 17:51:53 -0000 On Jun 29, 2012, at 03:42 , Andriy Gapon wrote: > on 29/06/2012 10:35 Andriy Gapon said the following: >> Author: avg >> Date: Fri Jun 29 07:35:37 2012 >> New Revision: 237748 >> URL: http://svn.freebsd.org/changeset/base/237748 >>=20 >> Log: >> dtrace instruction decoder: add 0x0f 0x1f NOP opcode support >>=20 >> According to the AMD manual the whole range from 0x09 to 0x1f are = NOPs. >> Intel manual mentions only 0x1f. Use only Intel one for now, it = seems >> to be the one actually generated by compilers. >> Use gdb mnemonic for the operation: "nopw". >=20 > BTW, here I have a patch that brings our copy of dtrace dis_tables.c = to the > latest version available in OpenSolaris code: > http://people.freebsd.org/~avg/dtrace-disassm-osol.diff >=20 > I haven't studied at all what the newer code brings in, but it must be = some > fixes and improvements, I guess :-) > The change is mostly a mechanical merge, plus some changes on top to = get the > code to compile. > I've been using the code for a few weeks and haven't run into any = problems. >=20 > Should I put this change into the tree? Have you tried running the DTrace test suite on it? We have the suite = in the tree. If the suite passes similarly with and without the patch I'd say just = put it in and we'll go from there. It's quite a large patch, but, yes, much of it is mechanical changes. Best, George