From owner-svn-src-head@FreeBSD.ORG  Sat Jul 24 19:43:35 2010
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id C2CBB1065677;
	Sat, 24 Jul 2010 19:43:35 +0000 (UTC) (envelope-from gnn@freebsd.org)
Received: from vps.hungerhost.com (vps.hungerhost.com [216.38.53.176])
	by mx1.freebsd.org (Postfix) with ESMTP id DC5EB8FC13;
	Sat, 24 Jul 2010 19:43:35 +0000 (UTC)
Received: from host-216-220-114-135.dsl.bway.net ([216.220.114.135]
	helo=[192.168.99.42]) by vps.hungerhost.com with esmtpa (Exim 4.69)
	(envelope-from <gnn@freebsd.org>)
	id 1Ocjrp-0006q6-BD; Sat, 24 Jul 2010 14:54:37 -0400
Mime-Version: 1.0 (Apple Message framework v1081)
Content-Type: text/plain; charset=us-ascii
From: George Neville-Neil <gnn@freebsd.org>
In-Reply-To: <AANLkTikYRjLeC7z5fb34=DsAi2PvBZT5uM4xffVgL9Br@mail.gmail.com>
Date: Sat, 24 Jul 2010 14:54:36 -0400
Content-Transfer-Encoding: quoted-printable
Message-Id: <2A761020-866F-48C2-B8B9-8C847C668A25@freebsd.org>
References: <201007231753.o6NHresT072278@svn.freebsd.org>
	<AANLkTikYRjLeC7z5fb34=DsAi2PvBZT5uM4xffVgL9Br@mail.gmail.com>
To: pluknet <pluknet@gmail.com>
X-Mailer: Apple Mail (2.1081)
X-AntiAbuse: This header was added to track abuse,
	please include it with any abuse report
X-AntiAbuse: Primary Hostname - vps.hungerhost.com
X-AntiAbuse: Original Domain - freebsd.org
X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12]
X-AntiAbuse: Sender Address Domain - freebsd.org
X-Source: 
X-Source-Args: 
X-Source-Dir: 
Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org,
	src-committers@freebsd.org
Subject: Re: svn commit: r210428 - head/sys/dev/e1000
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 24 Jul 2010 19:43:35 -0000


On Jul 23, 2010, at 15:27 , pluknet wrote:

> On 23 July 2010 21:53, George V. Neville-Neil <gnn@freebsd.org> wrote:
>> Author: gnn
>> Date: Fri Jul 23 17:53:39 2010
>> New Revision: 210428
>> URL: http://svn.freebsd.org/changeset/base/210428
>>=20
>> Log:
>>  Fix a bug in the statistics code for tracking the head and
>>  tail pointers of the tx and rx queues.   We needed a SYSCTL_PROC
>>  to correctly get the values at run time.
>>=20
>>  Submitted by: Andrew Boyer aboyer at averesystems.com
>>  MFC after:    1 week
>>=20
>> Modified:
>>  head/sys/dev/e1000/if_igb.c
>>=20
>> Modified: head/sys/dev/e1000/if_igb.c
>> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>> --- head/sys/dev/e1000/if_igb.c Fri Jul 23 17:44:01 2010        =
(r210427)
>> +++ head/sys/dev/e1000/if_igb.c Fri Jul 23 17:53:39 2010        =
(r210428)
>> @@ -4927,6 +4927,74 @@ igb_update_vf_stats_counters(struct adap
>>  }
>>=20
>>=20
>> +/** igb_sysctl_tdh_handler - Handler function
>> + *  Retrieves the TDH value from the hardware
>> + */
>> +static int igb_sysctl_tdh_handler(SYSCTL_HANDLER_ARGS)
>> +{
>=20
> ^^
> This function definition (and three ones below) breaks style(9):
> "     The function type should be on a line by itself preceding the =
function."
>=20

Quite right, I've committed a style(9) fix.

Thanks,
George