From owner-p4-projects  Sun Jul  7  9: 0:29 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 0396337B407; Sun,  7 Jul 2002 09:00:25 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 53D5737B406
	for <perforce@freebsd.org>; Sun,  7 Jul 2002 09:00:24 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 121CC43E4A
	for <perforce@freebsd.org>; Sun,  7 Jul 2002 09:00:24 -0700 (PDT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: from freefall.freebsd.org (perforce@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g67G0NJU063154
	for <perforce@freebsd.org>; Sun, 7 Jul 2002 09:00:23 -0700 (PDT)
	(envelope-from bb+lists.freebsd.perforce@cyrus.watson.org)
Received: (from perforce@localhost)
	by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g67G0Nj3063151
	for perforce@freebsd.org; Sun, 7 Jul 2002 09:00:23 -0700 (PDT)
Date: Sun, 7 Jul 2002 09:00:23 -0700 (PDT)
Message-Id: <200207071600.g67G0Nj3063151@freefall.freebsd.org>
X-Authentication-Warning: freefall.freebsd.org: perforce set sender to bb+lists.freebsd.perforce@cyrus.watson.org using -f
From: Robert Watson <rwatson@FreeBSD.org>
Subject: PERFORCE change 13866 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://people.freebsd.org/~peter/p4db/chv.cgi?CH=13866

Change 13866 by rwatson@rwatson_paprika on 2002/07/07 08:59:26

	Apparently whoever decided to stick SAVENAME into the namei()
	arguments all over vfs_syscalls.c forgot that SAVENAME wasn't an
	operation, it's a flag, resulting in a panic on calls to mkfifo().
	Someone remind me why we've added SAVENAME all over the place anyway,
	it results in a lot of diffs and I'm not sure we're using it.

Affected files ...

.. //depot/projects/trustedbsd/mac/sys/kern/vfs_syscalls.c#48 edit

Differences ...

==== //depot/projects/trustedbsd/mac/sys/kern/vfs_syscalls.c#48 (text+ko) ====

@@ -1977,7 +1977,7 @@
 
 restart:
 	bwillwrite();
-	NDINIT(&nd, CREATE | SAVENAME, LOCKPARENT, UIO_USERSPACE,
+	NDINIT(&nd, CREATE, LOCKPARENT | SAVENAME, UIO_USERSPACE,
 	    SCARG(uap, path), td);
 	if ((error = namei(&nd)) != 0)
 		return (error);

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message