From owner-freebsd-bugs@FreeBSD.ORG  Wed Feb 13 22:50:02 2008
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A9F2816A418
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 13 Feb 2008 22:50:02 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 9858B13C47E
	for <freebsd-bugs@hub.freebsd.org>;
	Wed, 13 Feb 2008 22:50:02 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.2/8.14.2) with ESMTP id m1DMo2xT006485
	for <freebsd-bugs@freefall.freebsd.org>; Wed, 13 Feb 2008 22:50:02 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.2/8.14.1/Submit) id m1DMo2Ue006478;
	Wed, 13 Feb 2008 22:50:02 GMT (envelope-from gnats)
Date: Wed, 13 Feb 2008 22:50:02 GMT
Message-Id: <200802132250.m1DMo2Ue006478@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: Volker <volker@vwsoft.com>
Cc: 
Subject: Re: kern/93172: [isp] [patch] uintXX_t style(9) updates
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Volker <volker@vwsoft.com>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 13 Feb 2008 22:50:02 -0000

The following reply was made to PR kern/93172; it has been noted by GNATS.

From: Volker <volker@vwsoft.com>
To: bug-followup@FreeBSD.org, rmh@aybabtu.com
Cc:  
Subject: Re: kern/93172: [isp] [patch] uintXX_t style(9) updates
Date: Wed, 13 Feb 2008 23:45:23 +0100

 This is a multi-part message in MIME format.
 --------------000509000404090303030307
 Content-Type: text/plain; charset=ISO-8859-1
 Content-Transfer-Encoding: 7bit
 
 Robert,
 
 I checked the status of your PR and found src/sys/dev/isp/isp* does
 not use types u_int* anymore. History outdated your PR...
 
 But in src/usr.bin/cksum/cksum.c I found a discrepancy:
 
 there's a function pointer declared:
 void (*pfncn)(char *, u_int32_t, off_t);
 
 which will later be pointed to either psum1 or pcrc. These are defined as:
 
 void	psum1(char *, uint32_t, off_t);
 void	pcrc(char *, uint32_t, off_t);
 
 The function pointer declaration differs from function declaration
 (slightly and not causing trouble but it's awful).
 
 patch attached
 
 --------------000509000404090303030307
 Content-Type: text/x-patch;
  name="cksum.c.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline;
  filename="cksum.c.diff"
 
 --- usr.bin/cksum/cksum.c.orig	2008-02-13 23:37:31.000000000 +0100
 +++ usr.bin/cksum/cksum.c	2008-02-13 23:37:48.000000000 +0100
 @@ -70,7 +70,7 @@
  	off_t len;
  	char *fn, *p;
  	int (*cfncn)(int, uint32_t *, off_t *);
 -	void (*pfncn)(char *, u_int32_t, off_t);
 +	void (*pfncn)(char *, uint32_t, off_t);
  
  	if ((p = rindex(argv[0], '/')) == NULL)
  		p = argv[0];
 
 --------------000509000404090303030307--