From owner-freebsd-current@FreeBSD.ORG  Mon Apr 12 06:42:28 2010
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6D45E106564A
	for <freebsd-current@freebsd.org>; Mon, 12 Apr 2010 06:42:28 +0000 (UTC)
	(envelope-from bu7cher@yandex.ru)
Received: from forward5.mail.yandex.net (forward5.mail.yandex.net
	[77.88.46.21]) by mx1.freebsd.org (Postfix) with ESMTP id 1CE208FC14
	for <freebsd-current@freebsd.org>; Mon, 12 Apr 2010 06:42:27 +0000 (UTC)
Received: from smtp1.mail.yandex.net (smtp1.mail.yandex.net [77.88.46.101])
	by forward5.mail.yandex.net (Yandex) with ESMTP id 2EE7514D0589;
	Mon, 12 Apr 2010 10:42:26 +0400 (MSD)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yandex.ru; s=mail;
	t=1271054546; bh=aUGjWHcpTkxS4EVi5XrtpTqQpg+Wl8bl49eODZLxa/4=;
	h=Message-ID:Date:From:MIME-Version:To:CC:Subject:References:
	In-Reply-To:Content-Type:Content-Transfer-Encoding;
	b=FNEOO82wGMFrpx/AoWZMGgMsumokRTndQe72/dSKnAybyb96BbCW5BfsPVOIT7ffi
	Ez8Zi1zfu80hR/Zr/czlvwveadyxAVaHY8WUFBFGk9n05I/5hBhNaRzD9w5Z2gymy0
	Sby5icMUc6kk2K339LxNRywF/eFSXB3QeqpZLniw=
Received: from [127.0.0.1] (ns.kirov.so-ups.ru [77.72.136.145])
	by smtp1.mail.yandex.net (Yandex) with ESMTPSA id ECAB92900A3;
	Mon, 12 Apr 2010 10:42:25 +0400 (MSD)
Message-ID: <4BC2C0D1.9090700@yandex.ru>
Date: Mon, 12 Apr 2010 10:42:25 +0400
From: "Andrey V. Elsukov" <bu7cher@yandex.ru>
User-Agent: Mozilla Thunderbird 1.5 (FreeBSD/20051231)
MIME-Version: 1.0
To: Hizel Ildar <hizel@vyborg.ru>
References: <4BC1790F.1020205@lissyara.su>
	<20100412100756.1ef3af73@hzwork.vyborg.ru>
In-Reply-To: <20100412100756.1ef3af73@hzwork.vyborg.ru>
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit
X-Yandex-TimeMark: 1271054546
X-Yandex-Spam: 1
X-Yandex-Front: smtp1.mail.yandex.net
Cc: freebsd-current@freebsd.org
Subject: Re: ipfw bug on i386
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 12 Apr 2010 06:42:28 -0000

On 12.04.2010 10:07, Hizel Ildar wrote:
> Hey! I'm fix this bug :D
>
> patch:
>
> foo# diff -ruN main.c~ main.c
> --- main.c~     2010-03-04 19:54:56.000000000 +0300
> +++ main.c      2010-04-12 09:37:21.000000000 +0400
> @@ -553,7 +553,7 @@
>          }
>
>          while (fgets(buf, BUFSIZ, f)) {         /* read commands */
> -               char linename[10];
> +               char linename[11];
>                  char *args[2];
>
>                  lineno++;

Can you test your it with 100k lines? :)
I think it can be fixed with something similar to:

-               sprintf(linename, "Line %d", lineno);
+               snprintf(linename, sizeof(linename), "Line %d", lineno);

-- 
WBR, Andrey V. Elsukov