From owner-p4-projects@FreeBSD.ORG Sat Nov 8 09:45:30 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 88A5C106567C; Sat, 8 Nov 2008 09:45:30 +0000 (UTC) Delivered-To: perforce@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4D0C41065674 for ; Sat, 8 Nov 2008 09:45:30 +0000 (UTC) (envelope-from hselasky@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 3AE8E8FC18 for ; Sat, 8 Nov 2008 09:45:30 +0000 (UTC) (envelope-from hselasky@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.3/8.14.3) with ESMTP id mA89jTuw050723 for ; Sat, 8 Nov 2008 09:45:29 GMT (envelope-from hselasky@FreeBSD.org) Received: (from perforce@localhost) by repoman.freebsd.org (8.14.3/8.14.3/Submit) id mA89jT6I050721 for perforce@freebsd.org; Sat, 8 Nov 2008 09:45:29 GMT (envelope-from hselasky@FreeBSD.org) Date: Sat, 8 Nov 2008 09:45:29 GMT Message-Id: <200811080945.mA89jT6I050721@repoman.freebsd.org> X-Authentication-Warning: repoman.freebsd.org: perforce set sender to hselasky@FreeBSD.org using -f From: Hans Petter Selasky To: Perforce Change Reviews Cc: Subject: PERFORCE change 152651 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Nov 2008 09:45:30 -0000 http://perforce.freebsd.org/chv.cgi?CH=152651 Change 152651 by hselasky@hselasky_laptop001 on 2008/11/08 09:45:19 Remove double page offset checks. The check is now done inside the invalidate and flush functions. Affected files ... .. //depot/projects/usb/src/sys/dev/usb2/core/usb2_busdma.c#11 edit Differences ... ==== //depot/projects/usb/src/sys/dev/usb2/core/usb2_busdma.c#11 (text+ko) ==== @@ -1387,12 +1387,10 @@ while (nframes--) { - if (pc->page_offset_buf != pc->page_offset_end) { - if (pc->isread) { - usb2_pc_cpu_invalidate(pc); - } else { - usb2_pc_cpu_flush(pc); - } + if (pc->isread) { + usb2_pc_cpu_invalidate(pc); + } else { + usb2_pc_cpu_flush(pc); } pc++; } @@ -1423,11 +1421,8 @@ pc = xfer->frbuffers; while (nframes--) { - - if (pc->page_offset_buf != pc->page_offset_end) { - if (pc->isread) { - usb2_pc_cpu_invalidate(pc); - } + if (pc->isread) { + usb2_pc_cpu_invalidate(pc); } pc++; }