From owner-svn-src-all@FreeBSD.ORG Wed Sep 15 16:25:09 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0C3681065672; Wed, 15 Sep 2010 16:25:09 +0000 (UTC) (envelope-from avg@freebsd.org) Received: from citadel.icyb.net.ua (citadel.icyb.net.ua [212.40.38.140]) by mx1.freebsd.org (Postfix) with ESMTP id B5E228FC17; Wed, 15 Sep 2010 16:25:07 +0000 (UTC) Received: from odyssey.starpoint.kiev.ua (alpha-e.starpoint.kiev.ua [212.40.38.101]) by citadel.icyb.net.ua (8.8.8p3/ICyb-2.3exp) with ESMTP id TAA12069; Wed, 15 Sep 2010 19:25:05 +0300 (EEST) (envelope-from avg@freebsd.org) Message-ID: <4C90F361.4090106@freebsd.org> Date: Wed, 15 Sep 2010 19:25:05 +0300 From: Andriy Gapon User-Agent: Mozilla/5.0 (X11; U; FreeBSD amd64; en-US; rv:1.9.2.9) Gecko/20100909 Lightning/1.0b2 Thunderbird/3.1.3 MIME-Version: 1.0 To: John Baldwin References: <201009151002.o8FA2kvO029237@svn.freebsd.org> <201009151157.24735.jhb@freebsd.org> In-Reply-To: <201009151157.24735.jhb@freebsd.org> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r212647 - head/sys/sys X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Sep 2010 16:25:09 -0000 on 15/09/2010 18:57 John Baldwin said the following: > On Wednesday, September 15, 2010 6:02:46 am Andriy Gapon wrote: >> Author: avg >> Date: Wed Sep 15 10:02:46 2010 >> New Revision: 212647 >> URL: http://svn.freebsd.org/changeset/base/212647 >> >> Log: >> sys/pcpu.h: remove a workaround for a fixed ld bug >> >> The workaround was incorrectly documented as having something to do with >> set_pcpu section's progbits, but in fact it was for incorrect placement >> of __start_set_pcpu because of the bug in ld. >> The bug was fixed in r210245, see commit message for details. >> >> A side-effect of the workaround was that a zero-size set_pcpu section was >> produced for modules, source code of which included pcpu.h but didn't >> actually define any dynamic per-cpu variables. >> This commit should remove the side-effect. >> >> The same workaround is present sys/net/vnet.h, has an analogous side-effect >> and can be removed as well. >> >> An UPDATING entry that warns about a need for recent ld is following. >> >> MFC after: 1 month >> >> Modified: >> head/sys/sys/pcpu.h >> >> Modified: head/sys/sys/pcpu.h >> ============================================================================== >> --- head/sys/sys/pcpu.h Wed Sep 15 09:48:18 2010 (r212646) >> +++ head/sys/sys/pcpu.h Wed Sep 15 10:02:46 2010 (r212647) >> @@ -44,24 +44,10 @@ >> >> /* >> * Define a set for pcpu data. >> - * >> - * We don't use SET_DECLARE because it defines the set as 'a' when we >> - * want 'aw'. gcc considers uninitialized data in a separate section >> - * writable, and there is no generic zero initializer that works for >> - * structs and scalars. >> */ >> extern uintptr_t *__start_set_pcpu; >> extern uintptr_t *__stop_set_pcpu; > > Given that you removed this comment, can you now use SET_DECLARE() here? No, why, for what do you want it to use? -- Andriy Gapon