From owner-freebsd-bugs@FreeBSD.ORG  Sat May 30 09:00:09 2009
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@hub.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 4F8331065672
	for <freebsd-bugs@hub.freebsd.org>;
	Sat, 30 May 2009 09:00:09 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
	[IPv6:2001:4f8:fff6::28])
	by mx1.freebsd.org (Postfix) with ESMTP id 3DB188FC1B
	for <freebsd-bugs@hub.freebsd.org>;
	Sat, 30 May 2009 09:00:09 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.14.3/8.14.3) with ESMTP id n4U909xr031659
	for <freebsd-bugs@freefall.freebsd.org>; Sat, 30 May 2009 09:00:09 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.14.3/8.14.3/Submit) id n4U909ub031658;
	Sat, 30 May 2009 09:00:09 GMT (envelope-from gnats)
Date: Sat, 30 May 2009 09:00:09 GMT
Message-Id: <200905300900.n4U909ub031658@freefall.freebsd.org>
To: freebsd-bugs@FreeBSD.org
From: dfilter@FreeBSD.ORG (dfilter service)
Cc: 
Subject: Re: kern/135069: commit references a PR
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: dfilter service <dfilter@FreeBSD.ORG>
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
	<mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 30 May 2009 09:00:09 -0000

The following reply was made to PR kern/135069; it has been noted by GNATS.

From: dfilter@FreeBSD.ORG (dfilter service)
To: bug-followup@FreeBSD.org
Cc:  
Subject: Re: kern/135069: commit references a PR
Date: Sat, 30 May 2009 08:53:26 +0000 (UTC)

 Author: adrian
 Date: Sat May 30 08:53:13 2009
 New Revision: 193085
 URL: http://svn.freebsd.org/changeset/base/193085
 
 Log:
   Make ipi_cpu() function as intended.
   
   IPI's in Xen are implemented through hypervisor event channels.
   The MP code creates a pair of IRQs for each base IPI per CPU
   (one for IPI function dispatch calls, one for IPI bitmap dispatch calls.)
   Using PCPU_GET() was returning the IRQ of the IPI handler for the
   current CPU; thus calls to ipi_cpu() were sending itself a message.
   Instead, looking up the IPI in the target CPU ipi-to-irq map is needed.
   
   Note: This doesn't fix Xen SMP (far from it!) but it at least
   sends IPI's to the right places. Next - sending IPIs..
   
   PR:	135069
 
 Modified:
   head/sys/xen/evtchn/evtchn.c
 
 Modified: head/sys/xen/evtchn/evtchn.c
 ==============================================================================
 --- head/sys/xen/evtchn/evtchn.c	Sat May 30 07:33:32 2009	(r193084)
 +++ head/sys/xen/evtchn/evtchn.c	Sat May 30 08:53:13 2009	(r193085)
 @@ -225,12 +225,15 @@ evtchn_do_upcall(struct trapframe *frame
  	}
  }
  
 +/*
 + * Send an IPI from the current CPU to the destination CPU.
 + */
  void
  ipi_pcpu(unsigned int cpu, int vector) 
  { 
          int irq;
  
 -	irq = PCPU_GET(ipi_to_irq[vector]);
 +	irq = pcpu_find(cpu)->pc_ipi_to_irq[vector];
  	
          notify_remote_via_irq(irq); 
  } 
 _______________________________________________
 svn-src-all@freebsd.org mailing list
 http://lists.freebsd.org/mailman/listinfo/svn-src-all
 To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"