From owner-p4-projects@FreeBSD.ORG  Sat Nov  8 11:29:35 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id DFCF91065674; Sat,  8 Nov 2008 11:29:34 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id A1FFE106567A;
	Sat,  8 Nov 2008 11:29:34 +0000 (UTC) (envelope-from mav@FreeBSD.org)
Received: from cmail.optima.ua (cmail.optima.ua [195.248.191.121])
	by mx1.freebsd.org (Postfix) with ESMTP id EE5E38FC16;
	Sat,  8 Nov 2008 11:29:33 +0000 (UTC) (envelope-from mav@FreeBSD.org)
X-Spam-Flag: SKIP
X-Spam-Yversion: Spamooborona-2.1.0
Received: from [212.86.226.226] (account mav@alkar.net HELO
	mavbook.mavhome.dp.ua)
	by cmail.optima.ua (CommuniGate Pro SMTP 5.2.9)
	with ESMTPSA id 227336569; Sat, 08 Nov 2008 12:29:31 +0200
Message-ID: <49156A0B.4030506@FreeBSD.org>
Date: Sat, 08 Nov 2008 12:29:31 +0200
From: Alexander Motin <mav@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.17 (X11/20081029)
MIME-Version: 1.0
To: Hans Petter Selasky <hselasky@FreeBSD.org>
References: <200811080910.mA89AgTZ048172@repoman.freebsd.org>
In-Reply-To: <200811080910.mA89AgTZ048172@repoman.freebsd.org>
Content-Type: text/plain; charset=KOI8-R; format=flowed
Content-Transfer-Encoding: 7bit
Cc: Perforce Change Reviews <perforce@FreeBSD.org>
Subject: Re: PERFORCE change 152649 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 08 Nov 2008 11:29:35 -0000

Hans Petter Selasky wrote:
> http://perforce.freebsd.org/chv.cgi?CH=152649
> 
> Change 152649 by hselasky@hselasky_laptop001 on 2008/11/08 09:09:50
> 
> 	
> 	Fix a serious BUSDMA bug: The initial virtual page offset is 
> 	not retained on the bounce pages, which is what the EHCI and
> 	the OHCI expects.

I'm sorry, but are you sure with this? If bounce page will have the same 
page offset as original data, then how bus_dma_tag_create()'s alignment 
parameter expected to work? What if data are misaligned, but hardware 
require alignment?

-- 
Alexander Motin