From owner-svn-src-all@FreeBSD.ORG Sun Apr 5 18:39:53 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AC296625; Sun, 5 Apr 2015 18:39:53 +0000 (UTC) Received: from mail-wi0-x22d.google.com (mail-wi0-x22d.google.com [IPv6:2a00:1450:400c:c05::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 51AD8D75; Sun, 5 Apr 2015 18:39:53 +0000 (UTC) Received: by wiaa2 with SMTP id a2so16170956wia.0; Sun, 05 Apr 2015 11:39:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; bh=rmzGSOdD3+P3H4p2ceYo3TqQtMjlQqXVfF3YEqEvqoI=; b=rLnKdQh7DZ3XjZXp59SqcVAyI5y4TCpOyCuAO71Dpo9HCPT07WnkJLQdNTHoehYW71 T8QHJHyMYrxp3ubDsE8txELxfWAt8ZHWLihI0M5zkVLoejJNbCUjj/nYZLvx64UvNZcB ytWzCm9P3HCt/Mpr3YzvfYKtwxgX0bp034AqxVmfcauxA8XhyOrdR/0CCfo0F2udaEAk XaDjK/YimhlkRc9rENuKG0L7fSle+keeKrhFWiUQ2IYbveYAjr0WQmDZbSohziYm2MfX 1/Xlat6iyWRi1GUvOq/eOW4lRjIKqamCrF/bIptIdmjOrtwuOs7uhX9xGUXJEx8ROJ5Q 5+VA== X-Received: by 10.194.77.7 with SMTP id o7mr6668960wjw.95.1428259191594; Sun, 05 Apr 2015 11:39:51 -0700 (PDT) Received: from dft-labs.eu (n1x0n-1-pt.tunnel.tserv5.lon1.ipv6.he.net. [2001:470:1f08:1f7::2]) by mx.google.com with ESMTPSA id pv2sm3312728wjc.33.2015.04.05.11.39.49 (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Sun, 05 Apr 2015 11:39:50 -0700 (PDT) Date: Sun, 5 Apr 2015 20:39:47 +0200 From: Mateusz Guzik To: Dmitry Chagin Subject: Re: svn commit: r281113 - head/sys/vm Message-ID: <20150405183947.GA24293@dft-labs.eu> References: <201504051825.t35IPO7t078390@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <201504051825.t35IPO7t078390@svn.freebsd.org> User-Agent: Mutt/1.5.21 (2010-09-15) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 05 Apr 2015 18:39:53 -0000 On Sun, Apr 05, 2015 at 06:25:24PM +0000, Dmitry Chagin wrote: > Author: dchagin > Date: Sun Apr 5 18:25:23 2015 > New Revision: 281113 > URL: https://svnweb.freebsd.org/changeset/base/281113 > > Log: > Fix wrong kassert msg in uma. > > PR: 199172 > Submitted by: luke.tw gmail com > MFC after: 1 week > > Modified: > head/sys/vm/uma_core.c > > Modified: head/sys/vm/uma_core.c > ============================================================================== > --- head/sys/vm/uma_core.c Sun Apr 5 17:09:58 2015 (r281112) > +++ head/sys/vm/uma_core.c Sun Apr 5 18:25:23 2015 (r281113) > @@ -3060,7 +3060,7 @@ uma_zone_set_fini(uma_zone_t zone, uma_f > uma_keg_t keg; > > keg = zone_first_keg(zone); > - KASSERT(keg != NULL, ("uma_zone_set_init: Invalid zone type")); > + KASSERT(keg != NULL, ("uma_zone_set_fini: Invalid zone type")); > KEG_LOCK(keg); > KASSERT(keg->uk_pages == 0, > ("uma_zone_set_fini on non-empty keg")); > @@ -3100,7 +3100,7 @@ uma_zone_set_freef(uma_zone_t zone, uma_ > uma_keg_t keg; > > keg = zone_first_keg(zone); > - KASSERT(keg != NULL, ("uma_zone_set_init: Invalid zone type")); > + KASSERT(keg != NULL, ("uma_zone_set_freef: Invalid zone type")); > KEG_LOCK(keg); > keg->uk_freef = freef; > KEG_UNLOCK(keg); > This seems to be a recurring problem (go figure). Was __func__ usage flamed over? I really think that linux's oops-like dump would be of great help here. It includes file + line info along with register dump which alone can give sufficient hints in several cases. -- Mateusz Guzik