From owner-svn-src-all@FreeBSD.ORG Wed Oct 13 22:20:25 2010 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 724C91065670; Wed, 13 Oct 2010 22:20:25 +0000 (UTC) (envelope-from obrien@NUXI.org) Received: from dragon.nuxi.org (trang.nuxi.org [74.95.12.85]) by mx1.freebsd.org (Postfix) with ESMTP id 4C6628FC14; Wed, 13 Oct 2010 22:20:25 +0000 (UTC) Received: from dragon.nuxi.org (obrien@localhost [127.0.0.1]) by dragon.nuxi.org (8.14.4/8.14.4) with ESMTP id o9DMKOKv017182; Wed, 13 Oct 2010 15:20:24 -0700 (PDT) (envelope-from obrien@dragon.nuxi.org) Received: (from obrien@localhost) by dragon.nuxi.org (8.14.4/8.14.4/Submit) id o9DMKO44017181; Wed, 13 Oct 2010 15:20:24 -0700 (PDT) (envelope-from obrien) Date: Wed, 13 Oct 2010 15:20:24 -0700 From: "David O'Brien" To: Bruce Evans Message-ID: <20101013222024.GA17164@dragon.NUXI.org> References: <201010121924.o9CJOgwn059485@svn.freebsd.org> <20101013133713.L1075@besplex.bde.org> <20101013040543.GB13694@dragon.NUXI.org> <20101013152037.S2102@besplex.bde.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20101013152037.S2102@besplex.bde.org> X-Operating-System: FreeBSD 9.0-CURRENT X-to-the-FBI-CIA-and-NSA: HI! HOW YA DOIN? User-Agent: Mutt/1.5.16 (2007-06-09) Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org Subject: Re: svn commit: r213744 - head/bin/sh X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: obrien@FreeBSD.org List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Oct 2010 22:20:25 -0000 On Wed, Oct 13, 2010 at 03:29:27PM +1100, Bruce Evans wrote: > Add __noinline or whatever attributes to STATIC (but keep static in > it) for the DEBUG >= 3 case if you are going that far. __noinline > should be a syntax error for variables, so this should also find any > STATICs still on variables. The spelling fix of changing STATIC to > what it actually means > (ASSORTED_HACKS_FOR_DEBUGGING_BUT_NOW_ONLY_FOR_FUNCTIONS) goes too far > for me. I've make all uses "static". Otherwise we have some of the functions and variable "STATIC" (if from 4.4BSD), and some others "static" (added later by FreeBSD). Surely this inconsistency isn't desired. -- -- David (obrien@FreeBSD.org)