From owner-svn-src-all@FreeBSD.ORG Sat Mar 22 13:26:00 2014 Return-Path: Delivered-To: svn-src-all@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id D30507E1; Sat, 22 Mar 2014 13:26:00 +0000 (UTC) Received: from mho-02-ewr.mailhop.org (mho-02-ewr.mailhop.org [204.13.248.72]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id A16F5D14; Sat, 22 Mar 2014 13:26:00 +0000 (UTC) Received: from c-24-8-230-52.hsd1.co.comcast.net ([24.8.230.52] helo=damnhippie.dyndns.org) by mho-02-ewr.mailhop.org with esmtpsa (TLSv1:AES256-SHA:256) (Exim 4.72) (envelope-from ) id 1WRLvz-000BW6-HC; Sat, 22 Mar 2014 13:25:59 +0000 Received: from [172.22.42.240] (revolution.hippie.lan [172.22.42.240]) by damnhippie.dyndns.org (8.14.3/8.14.3) with ESMTP id s2MDPt9s073290; Sat, 22 Mar 2014 07:25:55 -0600 (MDT) (envelope-from ian@FreeBSD.org) X-Mail-Handler: Dyn Standard SMTP by Dyn X-Originating-IP: 24.8.230.52 X-Report-Abuse-To: abuse@dyndns.com (see http://www.dyndns.com/services/sendlabs/outbound_abuse.html for abuse reporting information) X-MHO-User: U2FsdGVkX1/lfGRKiDO7k3ixk5gKqzv/ Subject: Re: svn commit: r263424 - head/sys/arm/conf From: Ian Lepore To: John-Mark Gurney In-Reply-To: <20140321190402.GT32089@funkthat.com> References: <201403201701.s2KH1L84024044@svn.freebsd.org> <20140321094316.76ccf459@bender.Home> <1395412070.81853.8.camel@revolution.hippie.lan> <20140321190402.GT32089@funkthat.com> Content-Type: text/plain; charset="us-ascii" Date: Sat, 22 Mar 2014 07:25:55 -0600 Message-ID: <1395494755.81853.38.camel@revolution.hippie.lan> Mime-Version: 1.0 X-Mailer: Evolution 2.32.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, Ruslan Bukin , src-committers@FreeBSD.org, Andrew Turner X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Mar 2014 13:26:00 -0000 On Fri, 2014-03-21 at 12:04 -0700, John-Mark Gurney wrote: > Ian Lepore wrote this message on Fri, Mar 21, 2014 at 08:27 -0600: > > On Fri, 2014-03-21 at 09:43 +0000, Andrew Turner wrote: > > > On Thu, 20 Mar 2014 17:01:21 +0000 (UTC) > > > Ruslan Bukin wrote: > > > > > > > Author: br > > > > Date: Thu Mar 20 17:01:21 2014 > > > > New Revision: 263424 > > > > URL: http://svnweb.freebsd.org/changeset/base/263424 > > > > > > > > Log: > > > > Disable debugging by default. > > > > > > I don't like this on head. I have found a number of issues that were > > > hidden because the kernel config most people were using for development > > > had WITNESS, INVARIANTS and DIAGNOSTIC disabled. > > I agree... HEAD needs these to make sure they are production ready... > > > I disagree. Witness is essentially useless anymore, because there are > > so many known LORs that nobody cares about when you report them that all > > it does is spews noise. Maybe it's useful when you're looking for a > > particular problem, but leaving it on all the time has just lost its > > value. > > I wouldn't be tracking down an AVILA bug if it wasn't for INVARIANTS.. > > Also, your complaint is solely about WITNESS not the other ones... > > Considering how many people are writing new drivers for ARM, and might > be introducing locking issues w/ those new drivers, WITNESS should be > included, plus, if you disable INVARIANTS, it means that all the > lock assert functions will be turned off, and we might miss an odd > calling stack which doesn't hold a lock or something... > > If you're using HEAD for performance, it's easy to turn these off.. > My complaint is only about witness. But... about being easy to turn off... how do they get turned off on non-head branches? Does re@ really have to go grovel through 77 config files turning off diagnostic options? Do we have to handle that difference when merging things to stable branches? Last time I tried to put something into arm/conf/DEFAULTS I got my hand slapped, but... putting the diagnostic options in there on head and not on stable branches would make the "touch 77 config files" problem go away. -- Ian