From owner-svn-src-head@FreeBSD.ORG  Sat May  2 22:07:06 2009
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 1CD0F106566C;
	Sat,  2 May 2009 22:07:06 +0000 (UTC) (envelope-from mav@FreeBSD.org)
Received: from cmail.optima.ua (cmail.optima.ua [195.248.191.121])
	by mx1.freebsd.org (Postfix) with ESMTP id 32DF78FC19;
	Sat,  2 May 2009 22:07:04 +0000 (UTC) (envelope-from mav@FreeBSD.org)
X-Spam-Flag: SKIP
X-Spam-Yversion: Spamooborona-2.1.0
Received: from [212.86.226.226] (account mav@alkar.net HELO
	mavbook.mavhome.dp.ua)
	by cmail.optima.ua (CommuniGate Pro SMTP 5.2.9)
	with ESMTPSA id 241810446; Sun, 03 May 2009 01:07:04 +0300
Message-ID: <49FCC404.6090105@FreeBSD.org>
Date: Sun, 03 May 2009 01:07:00 +0300
From: Alexander Motin <mav@FreeBSD.org>
User-Agent: Thunderbird 2.0.0.21 (X11/20090405)
MIME-Version: 1.0
To: "M. Warner Losh" <imp@bsdimp.com>
References: <200905012143.n41Lh4uS054073@svn.freebsd.org>
	<20090502.153808.-896932641.imp@bsdimp.com>
In-Reply-To: <20090502.153808.-896932641.imp@bsdimp.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org,
	src-committers@FreeBSD.org
Subject: Re: svn commit: r191733 - in head/sys: amd64/isa isa
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
	<svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
	<mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 02 May 2009 22:07:06 -0000

M. Warner Losh wrote:
> : Author: mav
> : Date: Fri May  1 21:43:04 2009
> : New Revision: 191733
> : URL: http://svn.freebsd.org/changeset/base/191733
> : 
> : Log:
> :   Add resume methods to i8254 and atrtc devices.
> 
> This likely obviates the need for pmtimer.c now.  You might want to
> investigate...

Yes, I have seen it.

> : Modified:
> :   head/sys/amd64/isa/clock.c
> :   head/sys/isa/atrtc.c
> 
> Shouldn't there be one for i386 too?

For i386 it is done by pmtimer now (that's why I haven't done it there), 
but there is no pmtimer driver for amd64. Actually both ways are not so 
perfect, as both restore timer interrupts quite late on resume process. 
In my case it is not fatal as i8254 is anyway ticking by default, just 
slower. But it seems to increase my system resume time to 10 seconds 
instead of usual 4-5. May be we should somehow enforce order of device 
resuming, or build some special event timers control infrastructure 
alike to PIC one.

Also, except restoring clocks interrupts, pmtimer restores system time 
on wakeup. For amd64 it is implemented in MD resume code now. We should 
decide which way to go. I don't very like pmtimer approach, as there is 
no any newbus relations between it and i8254/atrtc drivers.

-- 
Alexander Motin