From owner-svn-src-all@FreeBSD.ORG Wed Jul 14 17:02:16 2010 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5DF8D1065690; Wed, 14 Jul 2010 17:02:16 +0000 (UTC) (envelope-from mavbsd@gmail.com) Received: from mail-bw0-f54.google.com (mail-bw0-f54.google.com [209.85.214.54]) by mx1.freebsd.org (Postfix) with ESMTP id 596068FC3A; Wed, 14 Jul 2010 17:02:14 +0000 (UTC) Received: by bwz12 with SMTP id 12so94220bwz.13 for ; Wed, 14 Jul 2010 10:02:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :user-agent:mime-version:to:cc:subject:references:in-reply-to :x-enigmail-version:content-type:content-transfer-encoding; bh=MabQD0BoupYdBimKR1oIDyDs5VOSWdgMEDY7Yp9p9GY=; b=jZ6Neb7p8Qhmh8cwLMc/apKmlbKSKV8cJGVFpWtYXYSXzGH5hVoyJTslFDs+HaWIoT UZkgxzN7reaTaOXiS4iJ4ofJNhRpjCc2PAO6MOLXfzkzflwHVnAgMgdfykQmVkUgtF0e BOW5m/4FmgK/3ru6ipgr/3Jf2LJ+r08EvPcm8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:x-enigmail-version:content-type :content-transfer-encoding; b=vROtS5mRawwBSMj+PuoomdEftAqQrjlSqwY4xzZpmKkUQX4//91JtQmN5hG3kubE/f /wtsnNMZJqQS9bxy/5TDy4/2H9G0XOeyBPchX381jlsCPY+MVPlXKP68GTxdsOAkTNyL YyAVwf9uAqYEglCP08w6pPguEv7N0GQyHi7yY= Received: by 10.204.67.70 with SMTP id q6mr9284957bki.46.1279126933819; Wed, 14 Jul 2010 10:02:13 -0700 (PDT) Received: from mavbook2.mavhome.dp.ua (pc.mavhome.dp.ua [212.86.226.226]) by mx.google.com with ESMTPS id g11sm333282bkw.10.2010.07.14.10.02.12 (version=SSLv3 cipher=RC4-MD5); Wed, 14 Jul 2010 10:02:13 -0700 (PDT) Sender: Alexander Motin Message-ID: <4C3DED5A.3080806@FreeBSD.org> Date: Wed, 14 Jul 2010 20:01:14 +0300 From: Alexander Motin User-Agent: Thunderbird 2.0.0.23 (X11/20091212) MIME-Version: 1.0 To: John Baldwin References: <201007141331.o6EDVRp2078644@svn.freebsd.org> <201007141008.56110.jhb@freebsd.org> <4C3DDEF2.4090309@FreeBSD.org> <201007141241.36772.jhb@freebsd.org> In-Reply-To: <201007141241.36772.jhb@freebsd.org> X-Enigmail-Version: 0.96.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r210054 - in head/sys: conf kern x86/x86 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Jul 2010 17:02:16 -0000 John Baldwin wrote: > On Wednesday, July 14, 2010 11:59:46 am Alexander Motin wrote: >> John Baldwin wrote: >>> On Wednesday, July 14, 2010 9:31:27 am Alexander Motin wrote: >>>> Author: mav >>>> Date: Wed Jul 14 13:31:27 2010 >>>> New Revision: 210054 >>>> URL: http://svn.freebsd.org/changeset/base/210054 >>>> >>>> Log: >>>> Move timeevents.c to MI code, as it is not x86-specific. I already have >>>> it working on Marvell ARM SoCs, and it would be nice to unify timer > code >>>> between more platforms. >>>> >>>> Added: >>>> head/sys/kern/timeevents.c >>>> - copied unchanged from r210053, head/sys/x86/x86/timeevents.c >>>> Deleted: >>>> head/sys/x86/x86/timeevents.c >>>> Modified: >>>> head/sys/conf/files.amd64 >>>> head/sys/conf/files.i386 >>>> head/sys/conf/files.pc98 >>> Can this be merged with kern_et.c, >> They are different. kern_et.c provides event timer drivers API, >> timeevents.c consumes it to manage kernel clocks. kern_et.c >> theoretically can be used without timeevents.c if some other code >> consume timers, for example, exposing them to user-level. >> >> May be names indeed cryptic a bit, but I had no better ideas. >> >>> or perhaps called subr_eventtimers.c instead? >> Whatever you like, but why exactly so and why "subr_" important? > > The vast majority of files in sys/kern use some sort of prefix, either sys_*, > kern_*, subr_*, etc. subr_ was just a suggestion to avoid clashing with > kern_et.c. If timeevents.c is specific to clocks then maybe it should have > 'clock' in its name somehow? Right now having kern_et == kern_eventtimer.c > and timeevents.c is a bit ambiguous. Somehow making it clear that > timeevents.c is for clocks might help. We already have kern_clock.c and subr_clock.c. kern_clock.c is quite close by meaning. What's about kern_clocksource.c? -- Alexander Motin