From owner-cvs-src  Fri Feb 14 13:47:57 2003
Delivered-To: cvs-src@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 346EC37B401; Fri, 14 Feb 2003 13:47:54 -0800 (PST)
Received: from HAL9000.homeunix.com (12-233-57-224.client.attbi.com [12.233.57.224])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 2E0C143FBF; Fri, 14 Feb 2003 13:47:53 -0800 (PST)
	(envelope-from dschultz@uclink.Berkeley.EDU)
Received: from HAL9000.homeunix.com (localhost [127.0.0.1])
	by HAL9000.homeunix.com (8.12.6/8.12.5) with ESMTP id h1ELlnbL002684;
	Fri, 14 Feb 2003 13:47:49 -0800 (PST)
	(envelope-from dschultz@uclink.Berkeley.EDU)
Received: (from das@localhost)
	by HAL9000.homeunix.com (8.12.6/8.12.5/Submit) id h1ELlnOv002683;
	Fri, 14 Feb 2003 13:47:49 -0800 (PST)
	(envelope-from dschultz@uclink.Berkeley.EDU)
Date: Fri, 14 Feb 2003 13:47:48 -0800
From: David Schultz <dschultz@uclink.Berkeley.EDU>
To: Alfred Perlstein <alfred@FreeBSD.ORG>
Cc: Sam Leffler <sam@errno.com>, src-committers@FreeBSD.ORG,
	cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/sys/kern kern_shutdown.c
Message-ID: <20030214214748.GA2520@HAL9000.homeunix.com>
Mail-Followup-To: Alfred Perlstein <alfred@FreeBSD.ORG>,
	Sam Leffler <sam@errno.com>, src-committers@FreeBSD.ORG,
	cvs-src@FreeBSD.ORG, cvs-all@FreeBSD.ORG
References: <200302141244.h1ECimG1059062@repoman.freebsd.org> <275601c2d43b$ebd9e580$52557f42@errno.com> <20030214191957.GO93252@elvis.mu.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030214191957.GO93252@elvis.mu.org>
Sender: owner-cvs-src@FreeBSD.ORG
Precedence: bulk
List-ID: <cvs-src.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20cvs-src>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20cvs-src>
X-Loop: FreeBSD.ORG

Thus spake Alfred Perlstein <alfred@FreeBSD.ORG>:
> * Sam Leffler <sam@errno.com> [030214 07:15] wrote:
> > > alfred      2003/02/14 04:44:48 PST
> > >
> > >   Modified files:
> > >     sys/kern             kern_shutdown.c
> > >   Log:
> > >   style.
> > >
> > >   Revision  Changes    Path
> > >   1.141     +20 -8     src/sys/kern/kern_shutdown.c
> > >
> > http://cvsweb.FreeBSD.org/src/sys/kern/kern_shutdown.c.diff?r1=1.140&r2=1.14
> > 1
> > 
> > More like "gratuitous style".
> 
> More like when looking at the file in otder to fix other things I was so
> turned off by it that it offended me and for that reason needed fixing.

A single extra space at the end of a line offends you?  Some of
the ``style problems'' fixed by this commit aren't even in
style(9).  However, the following IS in style(9):

	Stylistic changes (including whitespace changes) are hard
	on the source repository and are to be avoided without
	good reason.

People don't seem to understand that violating this principle
makes it very hard to maintain local patches.  If the file is
being modified heavily anyway and there are major formatting bugs,
then there's nothing wrong with a few style fixes, but people need
to keep in mind that they *are* creating a hassle for others.
Don't take this personally, even though I'm using this commit as
an example; this is a generic complaint of mine against a practice,
not meant as an attack on any specific individuals.

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-src" in the body of the message