From owner-freebsd-current@FreeBSD.ORG  Wed Aug 24 12:49:58 2005
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
X-Original-To: current@freebsd.org
Delivered-To: freebsd-current@FreeBSD.ORG
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 1AA5116A41F
	for <current@freebsd.org>; Wed, 24 Aug 2005 12:49:58 +0000 (GMT)
	(envelope-from imura@ryu16.org)
Received: from mail.ryu16.org (221x249x107x70.ap221.ftth.ucom.ne.jp
	[221.249.107.70])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 518B043D46
	for <current@freebsd.org>; Wed, 24 Aug 2005 12:49:56 +0000 (GMT)
	(envelope-from imura@ryu16.org)
Received: from redeye.xt.ryu16.org (localhost [127.0.0.1])
	by mail.ryu16.org (8.12.9p1/8.12.9) with ESMTP id j7OCnkn7062448;
	Wed, 24 Aug 2005 21:49:46 +0900 (JST)
	(envelope-from imura@redeye.xt.ryu16.org)
Received: (from imura@localhost)
	by redeye.xt.ryu16.org (8.12.9p1/8.12.9/Submit) id j7OCnjb5062447;
	Wed, 24 Aug 2005 21:49:45 +0900 (JST) (envelope-from imura)
Date: Wed, 24 Aug 2005 21:49:45 +0900
From: "R. Imura" <imura@ryu16.org>
To: Rudolf Cejka <cejkar@fit.vutbr.cz>
Message-ID: <20050824124945.GB62229%imura@ryu16.org>
References: <20050821092816.GA51886%imura@ryu16.org>
	<20050823143456.GA79107@fit.vutbr.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20050823143456.GA79107@fit.vutbr.cz>
User-Agent: Mutt/1.4.1i-ja.1
Cc: current@freebsd.org
Subject: Re: kiconv related enhancement
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 24 Aug 2005 12:49:58 -0000

Hi,

On Tue, Aug 23, 2005 at 04:34:56PM +0200, Rudolf Cejka wrote:
> Please, do you have a plan to fix ranges too? You have either allocate
> sufficient space (ICONV_CSNMAXLEN + 1 instead of just ICONV_CSNMAXLEN),
> or check for string length >= ICONV_CSNMAXLEN instead of > ICONV_CSNMAXLEN.
> The second problem is that some strcpy()s could overwrite one byte
> after allocated space and strnpcy()s could produce unterminated
> strings - everything is around egrep -r "ICONV_C(S|NV)NMAXLEN" /usr/src.
> The last problem is that sys/libkern/iconv.c does not check the length
> of from and to in iconv_sysctl_add(), which can be source of unexpected
> results.

Thanks.  Fixed.
I remember that this is the second time you ask me about the issue.
I apologize that I'm late, and thank you for testing new patches.

Redards,
- R. Imura