From owner-freebsd-ports-bugs@FreeBSD.ORG Sun Jun 19 10:20:08 2011 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 7A8021065678 for ; Sun, 19 Jun 2011 10:20:08 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id 493B68FC22 for ; Sun, 19 Jun 2011 10:20:08 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id p5JAK8Or067092 for ; Sun, 19 Jun 2011 10:20:08 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id p5JAK8Tt067091; Sun, 19 Jun 2011 10:20:08 GMT (envelope-from gnats) Resent-Date: Sun, 19 Jun 2011 10:20:08 GMT Resent-Message-Id: <201106191020.p5JAK8Tt067091@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Chris Rees Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id AEAF0106564A for ; Sun, 19 Jun 2011 10:18:19 +0000 (UTC) (envelope-from utisoft@hotmail.com) Received: from blu0-omc1-s3.blu0.hotmail.com (blu0-omc1-s3.blu0.hotmail.com [65.55.116.14]) by mx1.freebsd.org (Postfix) with ESMTP id 6585F8FC0A for ; Sun, 19 Jun 2011 10:18:19 +0000 (UTC) Received: from BLU0-SMTP97 ([65.55.116.8]) by blu0-omc1-s3.blu0.hotmail.com with Microsoft SMTPSVC(6.0.3790.4675); Sun, 19 Jun 2011 03:18:18 -0700 Received: from zeus.bayofrum.net ([90.216.242.219]) by BLU0-SMTP97.phx.gbl over TLS secured channel with Microsoft SMTPSVC(6.0.3790.4675); Sun, 19 Jun 2011 03:18:17 -0700 Received: from zeus.bayofrum.net (crees@localhost [127.0.0.1]) by zeus.bayofrum.net (8.14.4/8.14.4) with ESMTP id p5JAFLks033622 (version=TLSv1/SSLv3 cipher=DHE-DSS-AES256-SHA bits=256 verify=NO) for ; Sun, 19 Jun 2011 11:15:22 +0100 (BST) (envelope-from crees@zeus.bayofrum.net) Received: (from crees@localhost) by zeus.bayofrum.net (8.14.4/8.14.4/Submit) id p5JAFLwF033621; Sun, 19 Jun 2011 11:15:21 +0100 (BST) (envelope-from crees) Message-Id: Date: Sun, 19 Jun 2011 11:15:21 +0100 From: Chris Rees Sender: To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Cc: Subject: ports/158022: [PATCH] Fix port: net/samba35 Breaks with Windows Update X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: Chris Rees List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Jun 2011 10:20:08 -0000 >Number: 158022 >Category: ports >Synopsis: [PATCH] Fix port: net/samba35 Breaks with Windows Update >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Sun Jun 19 10:20:07 UTC 2011 >Closed-Date: >Last-Modified: >Originator: Chris Rees >Release: FreeBSD 8.2-RELEASE-p1 i386 >Organization: >Environment: System: FreeBSD zeus.bayofrum.net 8.2-RELEASE-p1 FreeBSD 8.2-RELEASE-p1 #0: Sat Apr 30 15:09:06 BST 2011 root@zeus.bayofrum.net:/usr/obj/usr/src/sys/ZEUS i386 >Description: https://bugzilla.samba.org/show_bug.cgi?id=8238 This patch is from the above bug -- a recent Windows Update broke Samba when using plaintext passwords. >How-To-Repeat: >Fix: New file files/patch-source3-smbd-negprot-c --- samba-ms-fix.diff begins here --- Index: Makefile =================================================================== RCS file: /exports/cvsroot-freebsd/ports/net/samba35/Makefile,v retrieving revision 1.6 diff -u -r1.6 Makefile --- Makefile 25 Feb 2011 01:32:01 -0000 1.6 +++ Makefile 19 Jun 2011 09:20:21 -0000 @@ -7,7 +7,7 @@ PORTNAME= ${SAMBA_BASENAME}35 PORTVERSION= 3.5.6 -PORTREVISION?= 2 +PORTREVISION?= 3 CATEGORIES?= net MASTER_SITES= ${MASTER_SITE_SAMBA} MASTER_SITE_SUBDIR= . old-versions rc pre Index: files/patch-source3-smbd-negprot-c =================================================================== RCS file: files/patch-source3-smbd-negprot-c diff -N files/patch-source3-smbd-negprot-c --- /dev/null 1 Jan 1970 00:00:00 -0000 +++ files/patch-source3-smbd-negprot-c 19 Jun 2011 09:20:21 -0000 @@ -0,0 +1,26 @@ +From 0b0c5596034a007b71785a0f36aaf40cf74b234d Mon Sep 17 00:00:00 2001 +From: Volker Lendecke +Date: Thu, 16 Jun 2011 22:20:49 +0200 +Subject: [PATCH] s3: Fix bug 8238 -- KB2536276 prevents access to shares + +Without this we were not sending the workgroup name in the negprot reply if +plain text passwords are used. +--- + source3/smbd/negprot.c | 1 + + 1 files changed, 1 insertions(+), 0 deletions(-) + +diff --git a/source3/smbd/negprot.c b/source3/smbd/negprot.c +index 81d29d9..51ad80d 100644 +--- a/source3/smbd/negprot.c ++++ b/source3/smbd/negprot.c +@@ -382,6 +382,7 @@ static void reply_nt1(struct smb_request *req, uint16 choice) + reply_nterror(req, NT_STATUS_NO_MEMORY); + return; + } ++ p += ret; + DEBUG(3,("not using SPNEGO\n")); + } else { + DATA_BLOB spnego_blob = negprot_spnego(); +-- +1.5.6.5 + --- samba-ms-fix.diff ends here --- -- This message has been scanned for viruses and dangerous content by MailScanner, and is believed to be clean. >Release-Note: >Audit-Trail: >Unformatted: