From owner-freebsd-bugs@FreeBSD.ORG Thu Sep 20 21:30:10 2012 Return-Path: Delivered-To: freebsd-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 1F5BF1065677 for ; Thu, 20 Sep 2012 21:30:10 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D4A158FC0C for ; Thu, 20 Sep 2012 21:30:09 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.5/8.14.5) with ESMTP id q8KLU9lx017178 for ; Thu, 20 Sep 2012 21:30:09 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.5/8.14.5/Submit) id q8KLU93u017177; Thu, 20 Sep 2012 21:30:09 GMT (envelope-from gnats) Resent-Date: Thu, 20 Sep 2012 21:30:09 GMT Resent-Message-Id: <201209202130.q8KLU93u017177@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Axel Dörfler Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 8E801106564A for ; Thu, 20 Sep 2012 21:21:16 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (red.freebsd.org [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 55EEE8FC08 for ; Thu, 20 Sep 2012 21:21:16 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.5/8.14.5) with ESMTP id q8KLLFPR041860 for ; Thu, 20 Sep 2012 21:21:15 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.5/8.14.5/Submit) id q8KLLFsC041859; Thu, 20 Sep 2012 21:21:15 GMT (envelope-from nobody) Message-Id: <201209202121.q8KLLFsC041859@red.freebsd.org> Date: Thu, 20 Sep 2012 21:21:15 GMT From: Axel Dörfler To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: misc/171825: ale driver msix setup typo X-BeenThere: freebsd-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Sep 2012 21:30:10 -0000 >Number: 171825 >Category: misc >Synopsis: ale driver msix setup typo >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Thu Sep 20 21:30:09 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Axel Dörfler >Release: head >Organization: Haiku >Environment: >Description: The number of MSI-X messages pci_alloc_msix() fills in (msixc) is never checked - instead, msic is checked. In r233888 the problem is in line 554, not sure if my patch manages to apply (it should be against the 9.0 release version where the line is 517). >How-To-Repeat: >Fix: Patch attached with submission follows: diff --git a/src/add-ons/kernel/drivers/network/ar81xx/dev/ale/if_ale.c b/src/add-ons/kernel/drivers/network/ar81xx/dev/ale/if_ale.c index 9c3dfd9..25da00a 100644 --- a/src/add-ons/kernel/drivers/network/ar81xx/dev/ale/if_ale.c +++ b/src/add-ons/kernel/drivers/network/ar81xx/dev/ale/if_ale.c @@ -514,7 +514,7 @@ ale_attach(device_t dev) if (msix_disable == 0 || msi_disable == 0) { if (msix_disable == 0 && msixc == ALE_MSIX_MESSAGES && pci_alloc_msix(dev, &msixc) == 0) { - if (msic == ALE_MSIX_MESSAGES) { + if (msixc == ALE_MSIX_MESSAGES) { device_printf(dev, "Using %d MSIX messages.\n", msixc); sc->ale_flags |= ALE_FLAG_MSIX; >Release-Note: >Audit-Trail: >Unformatted: