From owner-p4-projects  Wed Jul 10 17:20:26 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 9F8A037B405; Wed, 10 Jul 2002 17:20:14 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.FreeBSD.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 5B7FC37B407
	for <perforce@freebsd.org>; Wed, 10 Jul 2002 17:20:04 -0700 (PDT)
Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id F21D143E3B
	for <perforce@freebsd.org>; Wed, 10 Jul 2002 17:20:03 -0700 (PDT)
	(envelope-from peter@freebsd.org)
Received: from freefall.freebsd.org (perforce@localhost [127.0.0.1])
	by freefall.freebsd.org (8.12.4/8.12.4) with ESMTP id g6B0K3JU078448
	for <perforce@freebsd.org>; Wed, 10 Jul 2002 17:20:03 -0700 (PDT)
	(envelope-from peter@freebsd.org)
Received: (from perforce@localhost)
	by freefall.freebsd.org (8.12.4/8.12.4/Submit) id g6B0K3TO078445
	for perforce@freebsd.org; Wed, 10 Jul 2002 17:20:03 -0700 (PDT)
Date: Wed, 10 Jul 2002 17:20:03 -0700 (PDT)
Message-Id: <200207110020.g6B0K3TO078445@freefall.freebsd.org>
X-Authentication-Warning: freefall.freebsd.org: perforce set sender to peter@freebsd.org using -f
From: Peter Wemm <peter@FreeBSD.org>
Subject: PERFORCE change 14065 for review
To: Perforce Change Reviews <perforce@freebsd.org>
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

http://people.freebsd.org/~peter/p4db/chv.cgi?CH=14065

Change 14065 by peter@peter_daintree on 2002/07/10 17:19:11

	fix some oops's.  s/atomic_store_int_rel/atomic_store_rel_int/
	(cut/pasted from jhb's suggestion).
	Fix comment within comment.

Affected files ...

.. //depot/projects/pmap/sys/i386/i386/mp_machdep.c#19 edit

Differences ...

==== //depot/projects/pmap/sys/i386/i386/mp_machdep.c#19 (text+ko) ====

@@ -2261,7 +2261,7 @@
 	mtx_lock_spin(&smp_tlb_mtx);
 	smp_tlb_addr1 = addr1;
 	smp_tlb_addr2 = addr2;
-	atomic_store_int_rel(&smp_tlb_wait, 0);
+	atomic_store_rel_int(&smp_tlb_wait, 0);
 	ipi_all_but_self(vector);
 	while (smp_tlb_wait < ncpu)
 		ia32_pause();
@@ -2278,8 +2278,8 @@
  *	bits++;
  * }
  * and
- * while (lsb = (m & -m)) {	/* This is magic too */
- * 	m &= ~lsb;		/* or: m ^= lsb */
+ * while (lsb = (m & -m)) {	// This is magic too
+ * 	m &= ~lsb;		// or: m ^= lsb
  *	bits++;
  * }
  * Both of these latter forms do some very strange things on gcc-3.1 with
@@ -2332,7 +2332,7 @@
 	mtx_lock_spin(&smp_tlb_mtx);
 	smp_tlb_addr1 = addr1;
 	smp_tlb_addr2 = addr2;
-	atomic_store_int_rel(&smp_tlb_wait, 0);
+	atomic_store_rel_int(&smp_tlb_wait, 0);
 	if (mask == (u_int)-1)
 		ipi_all_but_self(vector);
 	else

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message