From owner-p4-projects@FreeBSD.ORG  Sat Jul 22 11:51:51 2006
Return-Path: <owner-p4-projects@FreeBSD.ORG>
X-Original-To: p4-projects@freebsd.org
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 09D4A16A4E0; Sat, 22 Jul 2006 11:51:51 +0000 (UTC)
X-Original-To: perforce@freebsd.org
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id D8B2516A4DE
	for <perforce@freebsd.org>; Sat, 22 Jul 2006 11:51:50 +0000 (UTC)
	(envelope-from piso@freebsd.org)
Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115])
	by mx1.FreeBSD.org (Postfix) with ESMTP id A6CE443D45
	for <perforce@freebsd.org>; Sat, 22 Jul 2006 11:51:50 +0000 (GMT)
	(envelope-from piso@freebsd.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k6MBpoR4030088
	for <perforce@freebsd.org>; Sat, 22 Jul 2006 11:51:50 GMT
	(envelope-from piso@freebsd.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k6MBpoLS030085
	for perforce@freebsd.org; Sat, 22 Jul 2006 11:51:50 GMT
	(envelope-from piso@freebsd.org)
Date: Sat, 22 Jul 2006 11:51:50 GMT
Message-Id: <200607221151.k6MBpoLS030085@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	piso@freebsd.org using -f
From: Paolo Pisati <piso@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Cc: 
Subject: PERFORCE change 102136 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sat, 22 Jul 2006 11:51:51 -0000

http://perforce.freebsd.org/chv.cgi?CH=102136

Change 102136 by piso@piso_longino on 2006/07/22 11:51:17

	use IF_FAST macro instead of checking for INTR_FAST in flags,
	and place a comment about bus-related data struct that  
	don't record the filter function.

Affected files ...

.. //depot/projects/soc2006/intr_filter/dev/pccbb/pccbb.c#3 edit
.. //depot/projects/soc2006/intr_filter/dev/pccbb/pccbbvar.h#3 edit

Differences ...

==== //depot/projects/soc2006/intr_filter/dev/pccbb/pccbb.c#3 (text+ko) ====

@@ -361,7 +361,7 @@
 	 * least common denominator until the base system supports mixing
 	 * and matching better.
 	 */
-	if ((flags & INTR_FAST) != 0)
+	if (IS_FAST(filter, intr))
 		return (EINVAL);
 	ih = malloc(sizeof(struct cbb_intrhand), M_DEVBUF, M_NOWAIT);
 	if (ih == NULL)

==== //depot/projects/soc2006/intr_filter/dev/pccbb/pccbbvar.h#3 (text+ko) ====

@@ -31,7 +31,14 @@
  * Structure definitions for the Cardbus Bridge driver
  */
 
+/*  
+ *  XXX this structure and all the code that manipulates
+ *  it don't support interrupt filter model.
+ */
 struct cbb_intrhand {
+#if 0
+	driver_filter_t *filter;
+#endif
 	driver_intr_t	*intr;
 	void 		*arg;
 	struct cbb_softc *sc;