From owner-cvs-src@FreeBSD.ORG  Mon Feb  5 13:11:41 2007
Return-Path: <owner-cvs-src@FreeBSD.ORG>
X-Original-To: cvs-src@FreeBSD.org
Delivered-To: cvs-src@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52])
	by hub.freebsd.org (Postfix) with ESMTP id 5B7E416A405;
	Mon,  5 Feb 2007 13:11:41 +0000 (UTC)
	(envelope-from rea-fbsd@codelabs.ru)
Received: from pobox.codelabs.ru (pobox.codelabs.ru [144.206.177.45])
	by mx1.freebsd.org (Postfix) with ESMTP id 15F6B13C4AA;
	Mon,  5 Feb 2007 13:11:41 +0000 (UTC)
	(envelope-from rea-fbsd@codelabs.ru)
Received: from codelabs.ru (pobox.codelabs.ru [144.206.177.45])
	by pobox.codelabs.ru with esmtpsa (TLSv1:AES256-SHA:256)
	id 1HE3Kz-000E3G-9f; Mon, 05 Feb 2007 15:52:49 +0300
Date: Mon, 5 Feb 2007 15:52:44 +0300
From: Eygene Ryabinkin <rea-fbsd@codelabs.ru>
To: Gleb Smirnoff <glebius@FreeBSD.org>
Message-ID: <20070205125244.GO35552@codelabs.ru>
References: <200702030257.l132vkfT089439@repoman.freebsd.org>
	<20070205124332.GG1621@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=koi8-r
Content-Disposition: inline
In-Reply-To: <20070205124332.GG1621@FreeBSD.org>
Sender: rea-fbsd@codelabs.ru
X-Spam-Status: No, score=-2.5 required=4.0 tests=ALL_TRUSTED,AWL,BAYES_20
Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org,
	Bruce M Simpson <bms@FreeBSD.org>, cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/net if_tap.c
X-BeenThere: cvs-src@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the src tree <cvs-src.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-src>
List-Post: <mailto:cvs-src@freebsd.org>
List-Help: <mailto:cvs-src-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-src>,
	<mailto:cvs-src-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 05 Feb 2007 13:11:41 -0000

> btw, we have a strange situation with handling off non-broadcast
> frames not destined to us in general.
> 
> In a case, when we have generic Ethernet in promisc, and received foreign
> packets (on a hub, or a buggy switch), they are forwarded to ether_demux()
> and to upper layers respectively. Isn't this incorrect?
> 
> Moreover, in case of promisc + net.inet.ip.forwarding=1 our box will resend
> all the received foreign packets :(
> 
> What do you think about checking that (ether_dhost == ours || BCAST || MCAST)
> before sending packet to ether_demux?

If you will do so, please, do not forget to check if we're doing
bridging, because your proposal will break it. If I understand the
things correctly ;))
-- 
Eygene