From owner-freebsd-ports  Thu Mar  1 11:54:12 2001
Delivered-To: freebsd-ports@freebsd.org
Received: from blizzard.sabbo.net (blizzard.sabbo.net [193.193.218.18])
	by hub.freebsd.org (Postfix) with ESMTP
	id C57E137B719; Thu,  1 Mar 2001 11:54:01 -0800 (PST)
	(envelope-from max@vic.sabbo.net)
Received: from vic.sabbo.net (root@vic.sabbo.net [193.193.218.112])
	by blizzard.sabbo.net (8.10.1/8.10.1) with ESMTP id f21Jrsk12625;
	Thu, 1 Mar 2001 21:53:56 +0200
Received: (from max@localhost)
	by vic.sabbo.net (8.11.2/8.11.2) id f21Js4n59881;
	Thu, 1 Mar 2001 21:54:04 +0200 (EET)
	(envelope-from sobomax@FreeBSD.org)
From: Maxim Sobolev <sobomax@FreeBSD.ORG>
Message-Id: <200103011954.f21Js4n59881@vic.sabbo.net>
Subject: Re: [patch] which package functionality for pkg_info
To: rooneg@electricjellyfish.net (Garrett Rooney)
Date: Thu, 1 Mar 2001 21:53:53 +0200 (EET)
Cc: sobomax@FreeBSD.ORG (Maxim Sobolev), ports@FreeBSD.ORG,
	jhk@FreeBSD.ORG, gad@FreeBSD.ORG, reg@FreeBSD.ORG
In-Reply-To: <20010301133020.A23453@electricjellyfish.net> from "Garrett Rooney" at Mar 01, 2001 01:30:20 PM
X-Mailer: ELM [version 2.5 PL3]
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: owner-freebsd-ports@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.org

> On Thu, Mar 01, 2001 at 07:55:24PM +0200, Maxim Sobolev wrote:
> > Attached please find revised patch that uses matchinstalled() instead of fts
> > loop. IMO the code looks much cleaner. I fixed several other issues as well
> > (leak of opened file, useless snprintf(&a, strlen(b), b) useless include etc.).
>
> [snip] 
> 
> done!
> 
> one more thing.  i notice that matchinstalled() returns a null terminated
> array of strings, but they don't seem to be being freed anywhere.  should
> they?

No, matchinstalled() does it automagically if invoked several times. ;)

> +.Op Fl W Ar filename

Probably should be ".Op Fl W Ar filename ..." (-W accepts multiple arguments).

Looks almost finished, I'll look if I can commit it tomorrow.

Thanks!

-Maxim

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message