From owner-cvs-all@FreeBSD.ORG Tue Feb 27 19:17:25 2007 Return-Path: X-Original-To: cvs-all@freebsd.org Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id ADD1E16A404; Tue, 27 Feb 2007 19:17:25 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (grnl-static-02-0046.dsl.iowatelecom.net [69.66.56.110]) by mx1.freebsd.org (Postfix) with ESMTP id 46CF813C4A6; Tue, 27 Feb 2007 19:17:25 +0000 (UTC) (envelope-from brooks@lor.one-eyed-alien.net) Received: from lor.one-eyed-alien.net (localhost [127.0.0.1]) by lor.one-eyed-alien.net (8.13.8/8.13.8) with ESMTP id l1RJHMi0041020; Tue, 27 Feb 2007 13:17:22 -0600 (CST) (envelope-from brooks@lor.one-eyed-alien.net) Received: (from brooks@localhost) by lor.one-eyed-alien.net (8.13.8/8.13.8/Submit) id l1RJHLL3041019; Tue, 27 Feb 2007 13:17:21 -0600 (CST) (envelope-from brooks) Date: Tue, 27 Feb 2007 13:17:21 -0600 From: Brooks Davis To: mjacob@freebsd.org Message-ID: <20070227191721.GA40604@lor.one-eyed-alien.net> References: <200702091903.l19J3Ik5099479@repoman.freebsd.org> <86k5y6p9t2.fsf@dwp.des.no> <20070226172130.GB21095@lor.one-eyed-alien.net> <86vehohs7f.fsf@dwp.des.no> <20070227101456.H44348@ns1.feral.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="y0ulUmNC+osPPQO6" Content-Disposition: inline In-Reply-To: <20070227101456.H44348@ns1.feral.com> User-Agent: Mutt/1.5.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-3.0 (lor.one-eyed-alien.net [127.0.0.1]); Tue, 27 Feb 2007 13:17:22 -0600 (CST) Cc: Dag-Erling =?unknown-8bit?Q?Sm=F8rgrav?= , Brooks Davis , src-committers@freebsd.org, cvs-all@freebsd.org, cvs-src@freebsd.org Subject: Re: cvs commit: src/sys/amd64/conf GENERIC src/sys/i386/conf GENERIC src/sys/ia64/conf GENERIC src/sys/pc98/conf GENERIC src/sys/powerpc/conf GENERIC src/sys/sparc64/conf GENERIC src/sys/sun4v/conf GENERIC X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 27 Feb 2007 19:17:25 -0000 --y0ulUmNC+osPPQO6 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Feb 27, 2007 at 10:16:16AM -0800, mjacob@freebsd.org wrote: >=20 > I'm inclined to agree with Dag-Erling here. Originally I was=20 > pretty happy that this got turned on automatically, but on the whole I=20 > think the points made are good ones. I've reread Dag-Erling's post and I still don't agree that it should be removed, but since this seems to be the consensus I'll wait few more hours to see if that changes and then remove it until something is done to prevent problems with duplicate labels. The basic reason I don't agree is that it requires effort to trip over this bug. In no circumstance what to so ever will simply having this option in your kernel cause any harm. Only if you add entries to your fstab will problems occur. I don't see how not putting it in GENERIC will fix this pilot error. Using labels in sysinstall is obviously premature, but letting people use them a bit more seems like a very good idea. :( -- Brooks --y0ulUmNC+osPPQO6 Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFF5IPBXY6L6fI4GtQRAugMAKDAV19UHruF2RqZ8biRAsEpikb1qwCgvNds yPOifdHlQFUBJvBobZfWLEw= =5BDE -----END PGP SIGNATURE----- --y0ulUmNC+osPPQO6--