From owner-cvs-all  Fri Sep 18 11:37:31 1998
Return-Path: <owner-cvs-all>
Received: (from daemon@localhost)
          by hub.freebsd.org (8.8.8/8.8.8) id LAA06958
          for cvs-all-outgoing; Fri, 18 Sep 1998 11:37:31 -0700 (PDT)
          (envelope-from owner-cvs-all)
Received: from Kitten.mcs.com (Kitten.mcs.com [192.160.127.90])
          by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id LAA06941;
          Fri, 18 Sep 1998 11:37:27 -0700 (PDT)
          (envelope-from nash@Jupiter.Mcs.Net)
Received: from Jupiter.Mcs.Net (nash@Jupiter.mcs.net [192.160.127.88]) by Kitten.mcs.com (8.8.7/8.8.2) with ESMTP id NAA14729; Fri, 18 Sep 1998 13:36:57 -0500 (CDT)
Received: (from nash@localhost) by Jupiter.Mcs.Net (8.8.7/8.8.2) id NAA13101; Fri, 18 Sep 1998 13:36:56 -0500 (CDT)
Message-ID: <19980918133656.A6449@Mcs.Net>
Date: Fri, 18 Sep 1998 13:36:56 -0500
From: Alex Nash <nash@mcs.net>
To: Luigi Rizzo <luigi@labinfo.iet.unipi.it>
Cc: Eivind Eklund <eivind@yes.no>, cvs-committers@FreeBSD.ORG,
        cvs-all@FreeBSD.ORG
Subject: Re: cvs commit: src/sbin/ipfw ipfw.c src/sys/conf files src/sys/i386/isa if_ed.c if_ep.c if_lnc.c src/sys/net if_ethersubr.c src
Mail-Followup-To: Luigi Rizzo <luigi@labinfo.iet.unipi.it>,
	Eivind Eklund <eivind@yes.no>, cvs-committers@FreeBSD.ORG,
	cvs-all@FreeBSD.ORG
References: <19980918133152.09027@follo.net> <199809181132.NAA26299@labinfo.iet.unipi.it>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-Mailer: Mutt 0.93.2i
In-Reply-To: <199809181132.NAA26299@labinfo.iet.unipi.it>; from Luigi Rizzo on Fri, Sep 18, 1998 at 01:32:03PM +0200
Sender: owner-cvs-all@FreeBSD.ORG
X-Loop: FreeBSD.org
Precedence: bulk

On Fri, Sep 18, 1998 at 01:32:03PM +0200, Luigi Rizzo wrote:
> i have asked permission to Jordan and Garret on these specific issues.
> 
> About the ipfw binary compatibility my apologies because i forgot
> to mention that explicitly to the reviewers (and yes, now i remember
> you pointed that out), but the change it was absolutely necessary
> to have dummynet working.
> 
> In my partial defense:
> 
>   * the change only affects one binary, ipfw, and there is no user
>     interface change (i.e. you still have 10 ports available in a rule)

Changing FW_IFNLEN to an arbitrary value was a step backwards.  We were
already bitten by this once, and that's why it was set to IFNAMSIZ.  If
you want to argue that 16 character interface names will never exist,
change IFNAMSIZ.  Interface name length constraints don't belong in
ipfw.

Alex