From owner-svn-src-all@FreeBSD.ORG Thu Dec 22 09:27:17 2011 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 8F3EC106566C; Thu, 22 Dec 2011 09:27:17 +0000 (UTC) (envelope-from pawel@dawidek.net) Received: from mail.dawidek.net (60.wheelsystems.com [83.12.187.60]) by mx1.freebsd.org (Postfix) with ESMTP id 1B1BB8FC0A; Thu, 22 Dec 2011 09:27:16 +0000 (UTC) Received: from localhost (58.wheelsystems.com [83.12.187.58]) by mail.dawidek.net (Postfix) with ESMTPSA id A8AC2F9F; Thu, 22 Dec 2011 10:27:15 +0100 (CET) Date: Thu, 22 Dec 2011 10:26:13 +0100 From: Pawel Jakub Dawidek To: Alexander Best Message-ID: <20111222092613.GC1676@garage.freebsd.pl> References: <201112211716.pBLHGhDH078507@svn.freebsd.org> <201112211700.42772.jhb@freebsd.org> <20111221232754.GA51331@freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="7qSK/uQB79J36Y4o" Content-Disposition: inline In-Reply-To: <20111221232754.GA51331@freebsd.org> X-OS: FreeBSD 9.0-CURRENT amd64 User-Agent: Mutt/1.5.21 (2010-09-15) Cc: Adrian Chadd , src-committers@freebsd.org, John Baldwin , svn-src-all@freebsd.org, Dimitry Andric , svn-src-head@freebsd.org Subject: Re: svn commit: r228785 - in head/sys/dev/ath/ath_hal: ar5210 ar5211 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 22 Dec 2011 09:27:17 -0000 --7qSK/uQB79J36Y4o Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 21, 2011 at 11:27:54PM +0000, Alexander Best wrote: > the commits should stay. after all this is HEAD. this way all developers > running HEAD and with the appropriate ath hardware will test the changes.= if > dim@ really broke something, people will notice. >=20 > the changes should *not* be MFC'ed. but if no one complains until 10.0-RE= LEASE, > it's very unlikely he broke something. >=20 > plus...does it make a different, if you test HEAD with the changes presen= t or > test HEAD with the changes integrated via patches? >=20 > one way or the other you can test the changes and *if* something broke, t= he > commits can be reverted. Is this a joke? Having HEAD as stable as possible is very important. That's the only way to actually expect people (including developers (including myself!)) to run HEAD on their laptops and less important servers. Those people get upset as any other user if their systems stop working, because untested changes are being committed. This is not to pick on Dimitry, but on those who actually believe that it is ok to commit untested changes to HEAD. IT IS NOT. Maybe you are just confused, because the place you are looking for seems to be junkyard, but not HEAD, NEVER HEAD! BTW. This is a lesson we learned from 5-CURRENT. It was so unstable that nobody wanted to run it, and so unstable it was even hard to test changes on it. In turn it was becoming even more unstable, because people kept committing more untested code. Please, do never, ever encourage evil like that or I'll turn on mean Pawel:) --=20 Pawel Jakub Dawidek http://www.wheelsystems.com FreeBSD committer http://www.FreeBSD.org Am I Evil? Yes, I Am! http://yomoli.com --7qSK/uQB79J36Y4o Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.14 (FreeBSD) iEYEARECAAYFAk7y97UACgkQForvXbEpPzQFJQCg0jyxkvDWJMSpPUInOT1dD7S9 1GcAoJf4jBRxjypnkTRaqnLSa59S4Dgz =QN/H -----END PGP SIGNATURE----- --7qSK/uQB79J36Y4o--