From owner-svn-ports-all@FreeBSD.ORG Tue Dec 24 16:48:34 2013 Return-Path: Delivered-To: svn-ports-all@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 1033) id 44CED713; Tue, 24 Dec 2013 16:48:34 +0000 (UTC) Date: Tue, 24 Dec 2013 16:48:34 +0000 From: Alexey Dokuchaev To: Mathieu Arnold Subject: Re: svn commit: r337346 - branches/2014Q1/audio/ardour/files Message-ID: <20131224164834.GA42174@FreeBSD.org> References: <201312241254.rBOCsX8C087273@svn.freebsd.org> <20131224135023.GA94117@FreeBSD.org> <5B9F108459A3A26926CBB6AE@ogg.in.absolight.net> MIME-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5B9F108459A3A26926CBB6AE@ogg.in.absolight.net> User-Agent: Mutt/1.5.22 (2013-10-16) Cc: svn-ports-all@freebsd.org, svn-ports-branches@freebsd.org, ports-committers@freebsd.org X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Dec 2013 16:48:34 -0000 On Tue, Dec 24, 2013 at 03:18:51PM +0100, Mathieu Arnold wrote: > +--On 24 décembre 2013 13:50:24 +0000 Alexey Dokuchaev > | IMHO it should've been committed as part of r337343. There is nothing > | wrong with separating complicated fix into several commits (in head/), > | but if they are related, it makes more sense to merge them together, no? > > Yes, I could have done that, but the mfh script doesn't take more than one > revision to merge at a time, and I did not notice until after the facts > that there were two commits to the same port. > > If the original committer had asked for the merge, had gotten approval, and > had done it himself, he sure would have done it like you said ;-) Hehe, fair enough. As someone who was against branching the Ports Tree, my initial feeling was "fine, folks want to play with their new toy, why would I care?", hence I did not even check quarterly branch out. Perhaps I will reconsider, but hardly before I fix all my ports in head/. ./danfe P.S. It would still be nice to have that script fixed though. ;-)