From owner-freebsd-current@FreeBSD.ORG  Thu May 15 11:06:10 2003
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id C874837B401; Thu, 15 May 2003 11:06:10 -0700 (PDT)
Received: from sccrmhc02.attbi.com (sccrmhc02.attbi.com [204.127.202.62])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id E6D4143F3F; Thu, 15 May 2003 11:06:09 -0700 (PDT)
	(envelope-from julian@elischer.org)
Received: from interjet.elischer.org
	(12-232-168-4.client.attbi.com[12.232.168.4])
	by attbi.com (sccrmhc02) with ESMTP
	id <2003051518060800200b6kate>; Thu, 15 May 2003 18:06:09 +0000
Received: from localhost (localhost.elischer.org [127.0.0.1])
	by InterJet.elischer.org (8.9.1a/8.9.1) with ESMTP id LAA20178;
	Thu, 15 May 2003 11:06:07 -0700 (PDT)
Date: Thu, 15 May 2003 11:06:06 -0700 (PDT)
From: Julian Elischer <julian@elischer.org>
To: Martin Blapp <mb@imp.ch>
In-Reply-To: <20030515150938.N47986@cvs.imp.ch>
Message-ID: <Pine.BSF.4.21.0305151053060.12957-100000@InterJet.elischer.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
cc: re@freebsd.org
cc: FreeBSD current users <current@freebsd.org>
Subject: Re: (re@) FIX: malloc(9)/free(9) confusion bug in netgraph
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 15 May 2003 18:06:11 -0000

I found it..
it's a wrong malloc type on a FREE()
it only happens in shutting down the node in some cases so you shouldn't
see it much.

But here's the fix: (excuse cut'n'paste)


re@, can I commit this fix?

Index: ng_bridge.c
===================================================================
RCS file: /home/ncvs/src/sys/netgraph/ng_bridge.c,v
retrieving revision 1.18
diff -u -r1.18 ng_bridge.c
--- ng_bridge.c 19 Feb 2003 05:47:31 -0000      1.18
+++ ng_bridge.c 15 May 2003 18:03:55 -0000
@@ -987,7 +987,7 @@
        /* If node was shut down, this is the final lingering timeout */
        s = splnet();
        if (NG_NODE_NOT_VALID(node)) {
-               FREE(priv, M_NETGRAPH);
+               FREE(priv, M_NETGRAPH_BRIDGE);
                NG_NODE_SET_PRIVATE(node, NULL);
                NG_NODE_UNREF(node);
                splx(s);




On Thu, 15 May 2003, Martin Blapp wrote:

> 
> This just happened after I exited from X and did a soft reboot.
> Yes, vmware3 is installed with ng_bridgeing actived.
> 
> Probably freeing with wrong type, but maybe not here
> 
> panic()
> free()
> ng_bridge_timeout()
> softclock()
> ithread_loop()
> fork_exit()
> 
> Martin
> 
> Martin Blapp, <mb@imp.ch> <mbr@FreeBSD.org>
> ------------------------------------------------------------------
> ImproWare AG, UNIXSP & ISP, Zurlindenstrasse 29, 4133 Pratteln, CH
> Phone: +41 61 826 93 00 Fax: +41 61 826 93 01
> PGP: <finger -l mbr@freebsd.org>
> PGP Fingerprint: B434 53FC C87C FE7B 0A18 B84C 8686 EF22 D300 551E
> ------------------------------------------------------------------
> _______________________________________________
> freebsd-current@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-current
> To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org"
>