From owner-freebsd-geom@FreeBSD.ORG  Mon Mar 15 19:51:04 2010
Return-Path: <owner-freebsd-geom@FreeBSD.ORG>
Delivered-To: freebsd-geom@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 72FCA106564A;
	Mon, 15 Mar 2010 19:51:04 +0000 (UTC) (envelope-from jh@FreeBSD.org)
Received: from gw01.mail.saunalahti.fi (gw01.mail.saunalahti.fi
	[195.197.172.115])
	by mx1.freebsd.org (Postfix) with ESMTP id 384C78FC0A;
	Mon, 15 Mar 2010 19:51:03 +0000 (UTC)
Received: from a91-153-117-195.elisa-laajakaista.fi
	(a91-153-117-195.elisa-laajakaista.fi [91.153.117.195])
	by gw01.mail.saunalahti.fi (Postfix) with SMTP id A4FEC151777;
	Mon, 15 Mar 2010 21:51:00 +0200 (EET)
Date: Mon, 15 Mar 2010 21:51:00 +0200
From: Jaakko Heinonen <jh@FreeBSD.org>
To: freebsd-geom@FreeBSD.org, pjd@FreeBSD.org
Message-ID: <20100315195059.GA1331@a91-153-117-195.elisa-laajakaista.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.5.20 (2009-06-14)
Cc: 
Subject: geom_label and directories under /dev
X-BeenThere: freebsd-geom@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: GEOM-specific discussions and implementations
	<freebsd-geom.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-geom>
List-Post: <mailto:freebsd-geom@freebsd.org>
List-Help: <mailto:freebsd-geom-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-geom>,
	<mailto:freebsd-geom-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 15 Mar 2010 19:51:04 -0000


Hi,

I was working to fix problems with GEOM label class allowing some
problematic label names which can't represent proper files under /dev.
For example:

- empty label
- "." and ".."
- labels starting or ending with '/'
- labels ending with /.. (Due to a bug for example /..foo/.. is
  allowed.)

Then I noticed that directories are also problematic. Here's how to
panic your system:

# glabel create ab ad0
# glabel create ab/cd ad0
# ls -l /dev/label

I was going to suggest disallowing of '/' in labels but in past such
change has been reverted.

------------------------------------------------------------------------
r149339 | pjd | 2005-08-20 20:05:47 +0300 (Sat, 20 Aug 2005) | 5 lines

Back-out the change from revision 1.14 and allow for '/' in labels
again.

Convinced by:   green, Gavin Atkinson, dougb, gordon
MFC after:      1 day

------------------------------------------------------------------------

So it's probably a dead end to try to suggest disallowing of '/'?
Unfortunately it's not easy to fix all problems with directories. For
starters devfs doesn't support removal of directories at all.

Opinions?

-- 
Jaakko