From owner-freebsd-current@FreeBSD.ORG Thu May 15 11:12:56 2003 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 70D6237B401; Thu, 15 May 2003 11:12:56 -0700 (PDT) Received: from fledge.watson.org (fledge.watson.org [204.156.12.50]) by mx1.FreeBSD.org (Postfix) with ESMTP id 716DA43FA3; Thu, 15 May 2003 11:12:55 -0700 (PDT) (envelope-from robert@fledge.watson.org) Received: from fledge.watson.org (localhost [127.0.0.1]) by fledge.watson.org (8.12.9/8.12.9) with ESMTP id h4FICbOn023331; Thu, 15 May 2003 14:12:37 -0400 (EDT) (envelope-from robert@fledge.watson.org) Received: from localhost (robert@localhost)h4FICbD4023328; Thu, 15 May 2003 14:12:37 -0400 (EDT) (envelope-from robert@fledge.watson.org) Date: Thu, 15 May 2003 14:12:37 -0400 (EDT) From: Robert Watson X-Sender: robert@fledge.watson.org To: Julian Elischer In-Reply-To: Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII cc: Martin Blapp cc: re@freebsd.org cc: FreeBSD current users Subject: Re: (re@) FIX: malloc(9)/free(9) confusion bug in netgraph X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 May 2003 18:12:56 -0000 Approved. Robert N M Watson FreeBSD Core Team, TrustedBSD Projects robert@fledge.watson.org Network Associates Laboratories On Thu, 15 May 2003, Julian Elischer wrote: > I found it.. > it's a wrong malloc type on a FREE() > it only happens in shutting down the node in some cases so you shouldn't > see it much. > > But here's the fix: (excuse cut'n'paste) > > > re@, can I commit this fix? > > Index: ng_bridge.c > =================================================================== > RCS file: /home/ncvs/src/sys/netgraph/ng_bridge.c,v > retrieving revision 1.18 > diff -u -r1.18 ng_bridge.c > --- ng_bridge.c 19 Feb 2003 05:47:31 -0000 1.18 > +++ ng_bridge.c 15 May 2003 18:03:55 -0000 > @@ -987,7 +987,7 @@ > /* If node was shut down, this is the final lingering timeout */ > s = splnet(); > if (NG_NODE_NOT_VALID(node)) { > - FREE(priv, M_NETGRAPH); > + FREE(priv, M_NETGRAPH_BRIDGE); > NG_NODE_SET_PRIVATE(node, NULL); > NG_NODE_UNREF(node); > splx(s); > > > > > On Thu, 15 May 2003, Martin Blapp wrote: > > > > > This just happened after I exited from X and did a soft reboot. > > Yes, vmware3 is installed with ng_bridgeing actived. > > > > Probably freeing with wrong type, but maybe not here > > > > panic() > > free() > > ng_bridge_timeout() > > softclock() > > ithread_loop() > > fork_exit() > > > > Martin > > > > Martin Blapp, > > ------------------------------------------------------------------ > > ImproWare AG, UNIXSP & ISP, Zurlindenstrasse 29, 4133 Pratteln, CH > > Phone: +41 61 826 93 00 Fax: +41 61 826 93 01 > > PGP: > > PGP Fingerprint: B434 53FC C87C FE7B 0A18 B84C 8686 EF22 D300 551E > > ------------------------------------------------------------------ > > _______________________________________________ > > freebsd-current@freebsd.org mailing list > > http://lists.freebsd.org/mailman/listinfo/freebsd-current > > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" > > > > _______________________________________________ > freebsd-current@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-current > To unsubscribe, send any mail to "freebsd-current-unsubscribe@freebsd.org" >