From owner-cvs-src@FreeBSD.ORG Mon May 19 18:09:26 2008 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 916E8106567F; Mon, 19 May 2008 18:09:26 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [IPv6:2001:4f8:fff6::29]) by mx1.freebsd.org (Postfix) with ESMTP id 6196F8FC18; Mon, 19 May 2008 18:09:26 +0000 (UTC) (envelope-from cperciva@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m4JI9Qh5096468; Mon, 19 May 2008 18:09:26 GMT (envelope-from cperciva@repoman.freebsd.org) Received: (from cperciva@localhost) by repoman.freebsd.org (8.14.1/8.14.1/Submit) id m4JI9Qlk096467; Mon, 19 May 2008 18:09:26 GMT (envelope-from cperciva) Message-Id: <200805191809.m4JI9Qlk096467@repoman.freebsd.org> From: Colin Percival Date: Mon, 19 May 2008 18:09:26 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/usr.bin/tar write.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 May 2008 18:09:26 -0000 cperciva 2008-05-19 18:09:26 UTC FreeBSD src repository Modified files: usr.bin/tar write.c Log: There's no way for entry to possibly be NULL at the end of write_entry (in fact, there has never been any way for it to be NULL, going all the way back to revision 1.1 of this file), so remove the check and unconditionally free entry. Found by: Coverity Prevent Revision Changes Path 1.68 +1 -2 src/usr.bin/tar/write.c