From owner-svn-src-head@FreeBSD.ORG Wed Jan 21 01:40:35 2015 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id AA725652; Wed, 21 Jan 2015 01:40:35 +0000 (UTC) Received: from mail-pa0-x22c.google.com (mail-pa0-x22c.google.com [IPv6:2607:f8b0:400e:c03::22c]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 70898C79; Wed, 21 Jan 2015 01:40:35 +0000 (UTC) Received: by mail-pa0-f44.google.com with SMTP id et14so49421402pad.3; Tue, 20 Jan 2015 17:40:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=5V4pju5HMDwceqK8mTnCRm/8Rs9Ikk6h35jnz5pcPVQ=; b=jREJ26/ITR+bumrzafvnLyFWn/lp5Jn/VC/StUy7gPJpkWJEP/yp6ZgbjrDkZcTYF9 rVzv0p0NUtpYQrLRBdeMB9lSYPawKXF24ibPPM4Ezhd3e1Ml+e2Rnp2ikKnfdfmlrANT c2t2fUlGCNlCEcdGp3V8pUBeb29dARxKW6YARw2QpVt9xi6hvpj7AbfFxNnm5jzjWSbU xGMXUGO0NxhakU/emNAUWRzY7SnurK31ovpt+v0i40lhaXUaT0f1a/+GGCCVRxK3ZdAx uXjXM4ParzleOVbvJZAw9cDTiH6pg/A7tfA1cT3nVJpedQay6jFkXYd0BwMlL3tXBKPM DTPA== X-Received: by 10.70.32.195 with SMTP id l3mr34110118pdi.41.1421804434933; Tue, 20 Jan 2015 17:40:34 -0800 (PST) Received: from [10.192.166.0] (stargate.chelsio.com. [67.207.112.58]) by mx.google.com with ESMTPSA id cc3sm1215990pdb.67.2015.01.20.17.40.33 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 20 Jan 2015 17:40:33 -0800 (PST) Sender: Navdeep Parhar Message-ID: <54BF0390.8070003@FreeBSD.org> Date: Tue, 20 Jan 2015 17:40:32 -0800 From: Navdeep Parhar User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Pedro Giffuni , Luigi Rizzo , "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Subject: Re: svn commit: r276485 - in head/sys: conf dev/cxgbe modules/cxgbe/if_cxgbe References: <201412312319.sBVNJHca031041@svn.freebsd.org> <20150106203344.GB26068@ox> <54BEE07A.3070207@FreeBSD.org> <54BEE305.6020905@FreeBSD.org> <54BEF7CF.9030505@FreeBSD.org> <54BEFB79.6090806@FreeBSD.org> <54BF01F2.4030502@FreeBSD.org> In-Reply-To: <54BF01F2.4030502@FreeBSD.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Jan 2015 01:40:35 -0000 On 01/20/15 17:33, Pedro Giffuni wrote: > > On 01/20/15 20:06, Navdeep Parhar wrote: >> On 01/20/15 16:50, Pedro Giffuni wrote: >>> >>> On 01/20/15 18:21, Navdeep Parhar wrote: >>>> The problem reported by Luigi has been fixed in r277225 already. >>>> >>>> Regards, >>>> Navdeep >>>> >>> >>> But the fix is rather ugly, isn't it? I would personally prefer to just >>> kill the older >>> gcc but in the meantime updating it so that it behaves like the updated >>> gcc/clang would be better. IMHO. >> >> I'm not sure why you think the fix is ugly. Modifying the base >> compiler to deal with minor stuff like this seems excessive and I >> never even considered that. >> > > "Modifying the base compiler to deal with minor stuff like this" is > actually called > "an update" since upstream already did it: > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=10676 > > You could also call it "making it more compatible with clang and newer gcc" > > The base compiler is ugly as it can be but that's upstream's fault, not > the fault > those of us that were once condemned to add bandaids. Happily I am not > planning to touch it anymore ;). I'm not planning to touch it at all, and I'm happy too :-) Regards, Navdeep > > Pedro. > > >> Regards, >> Navdeep >> >>> >>> Pedro. >>> >>>> On 01/20/15 15:10, Pedro Giffuni wrote: >>>>> Hi; >>>>> >>>>> I got this patch from the OpenBSD-tech list[1]. >>>>> Perhaps this fixes the gcc issue? >>>>> >>>>> Apparently it's required for mesa too. >>>>> >>>>> Pedro. >>>>> >>>>> [1] http://article.gmane.org/gmane.os.openbsd.tech/40604 >>>>>