From owner-freebsd-ports@FreeBSD.ORG Tue Jan 19 01:36:31 2010 Return-Path: Delivered-To: freebsd-ports@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C7D17106568D for ; Tue, 19 Jan 2010 01:36:31 +0000 (UTC) (envelope-from dougb@FreeBSD.org) Received: from mail2.fluidhosting.com (mx21.fluidhosting.com [204.14.89.4]) by mx1.freebsd.org (Postfix) with ESMTP id 579138FC0A for ; Tue, 19 Jan 2010 01:36:31 +0000 (UTC) Received: (qmail 32137 invoked by uid 399); 19 Jan 2010 01:36:30 -0000 Received: from localhost (HELO foreign.dougb.net) (dougb@dougbarton.us@127.0.0.1) by localhost with ESMTPAM; 19 Jan 2010 01:36:30 -0000 X-Originating-IP: 127.0.0.1 X-Sender: dougb@dougbarton.us Message-ID: <4B550C9E.6040303@FreeBSD.org> Date: Mon, 18 Jan 2010 17:36:30 -0800 From: Doug Barton Organization: http://SupersetSolutions.com/ User-Agent: Mozilla/5.0 (X11; U; FreeBSD i386; en-US; rv:1.9.1.5) Gecko/20100114 Thunderbird/3.0 MIME-Version: 1.0 To: "Philip M. Gollucci" References: <4B54D17E.8000508@FreeBSD.org> <4B550975.8090800@p6m7g8.com> In-Reply-To: <4B550975.8090800@p6m7g8.com> X-Enigmail-Version: 1.0 OpenPGP: id=D5B2F0FB Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: freebsd-ports@freebsd.org Subject: Re: Why change to plist-sub for pkg-message? X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Jan 2010 01:36:31 -0000 On 01/18/10 17:23, Philip M. Gollucci wrote: > That particular one is questionable, but I'm sure if every post-install > message is in pkg-message or files/pkg-message.in it will help with > > > http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/122877 Ok, now I see where you're going with this. :) With respect to Wesley, the approach in the patch is bass-ackwards. You don't want to do anything with files named *pkg*message*, there are just too many variations. The only thing you want to worry about is /var/db/pkg/*/+DISPLAY. That way you can be sure of several useful things ... it's persistent (I.e., users can bring it up again with pkg_info), it's already post-processed, etc. etc. Modesty aside portmaster has some pretty mature code to deal with this, I suggest giving it a look before trying to reinvent it. As for the rest of the patch, I appreciate the POLA-awareness, but I would make this opt-OUT instead of opt-in, tool authors can easily opt out of it with a one-line fix, whereas the feature is very useful for the average user and I believe it should be enabled by default. It's one of the things that people tell me most often that they like about portmaster. Doug -- Improve the effectiveness of your Internet presence with a domain name makeover! http://SupersetSolutions.com/ Computers are useless. They can only give you answers. -- Pablo Picasso