From owner-cvs-all  Sat Apr  7 20:29:41 2001
Delivered-To: cvs-all@freebsd.org
Received: from dragon.nuxi.com (trang.nuxi.com [209.152.133.57])
	by hub.freebsd.org (Postfix) with ESMTP
	id BD60737B423; Sat,  7 Apr 2001 20:29:36 -0700 (PDT)
	(envelope-from obrien@NUXI.com)
Received: (from obrien@localhost)
	by dragon.nuxi.com (8.11.3/8.11.1) id f383Tac10623;
	Sat, 7 Apr 2001 20:29:36 -0700 (PDT)
	(envelope-from obrien)
Date: Sat, 7 Apr 2001 20:29:35 -0700
From: "David O'Brien" <obrien@FreeBSD.org>
To: Orion Hodson <orion@FreeBSD.org>, cvs-committers@FreeBSD.org,
	cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/dev/sound/pci cmi.c
Message-ID: <20010407202934.A10520@dragon.nuxi.com>
Reply-To: obrien@FreeBSD.org
References: <200104071416.f37EGX307097@freefall.freebsd.org> <3ACF75AD.C4DD23AE@urx.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
User-Agent: Mutt/1.2.5i
In-Reply-To: <3ACF75AD.C4DD23AE@urx.com>; from kstewart@urx.com on Sat, Apr 07, 2001 at 01:16:45PM -0700
X-Operating-System: FreeBSD 5.0-CURRENT
Organization: The NUXI BSD group
X-Pgp-Rsa-Fingerprint: B7 4D 3E E9 11 39 5F A3  90 76 5D 69 58 D9 98 7A
X-Pgp-Rsa-Keyid: 1024/34F9F9D5
Sender: owner-cvs-all@FreeBSD.ORG
Precedence: bulk
X-Loop: FreeBSD.ORG

On Sat, Apr 07, 2001 at 01:16:45PM -0700, Kent Stewart wrote:
> > orion       2001/04/07 07:16:33 PDT
> > 
> >   Modified files:        (Branch: RELENG_4)
> >     sys/dev/sound/pci    cmi.c
> >   Log:
> >   MFC sample rate fixes for release.
> > 
> >   Approved by:  jkh
> 
> This change breaks 4-stable.

And *EXACTLY* why the committer should have seriously considered what the
great bug / problem was that this commit addressed before asking JKH to
MFC it at this time.

Was it was worth the break in the build in this late phase of the release
cycle?  Or do all committers not realize what _RELEASE_CANDIDATE_ means?

If a commit was going to do something like this; I expect them to do a
`cvsup' and `make world' + kernel build from _virgin_ sources.  By
virgin, I mean `cd /usr && rm -rf src && cvs co src -rRELENG_4'.

The build has been broken now for several hours because the committer
didn't bother to perform this simple test.

-- 
-- David  (obrien@FreeBSD.org)

To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message