From owner-cvs-src Sun Feb 9 3:41:45 2003 Delivered-To: cvs-src@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 11E2F37B401; Sun, 9 Feb 2003 03:41:41 -0800 (PST) Received: from mail.chesapeake.net (chesapeake.net [205.130.220.14]) by mx1.FreeBSD.org (Postfix) with ESMTP id A068243F3F; Sun, 9 Feb 2003 03:41:40 -0800 (PST) (envelope-from jroberson@chesapeake.net) Received: from localhost (jroberson@localhost) by mail.chesapeake.net (8.11.6/8.11.6) with ESMTP id h19BfeR84857; Sun, 9 Feb 2003 06:41:40 -0500 (EST) (envelope-from jroberson@chesapeake.net) Date: Sun, 9 Feb 2003 06:41:40 -0500 (EST) From: Jeff Roberson To: Jeff Roberson Cc: src-committers@FreeBSD.org, , , Subject: Re: cvs commit: src/sys/fs/hpfs hpfs_vnops.c src/sys/fs/msdosfs msdosfs_vnops.c src/sys/fs/specfs spec_vnops.c src/sys/kern vfs_bio.c vfs_default.c src/sys/sys buf.h vnode.h src/sys/ufs/ff In-Reply-To: <200302091128.h19BSZ9I090320@repoman.freebsd.org> Message-ID: <20030209063654.A77658-100000@mail.chesapeake.net> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-cvs-src@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Sun, 9 Feb 2003, Jeff Roberson wrote: > - Cleanup unlocked accesses to buf flags by introducing a new b_vflag member > that is protected by the vnode lock. > - Move B_SCANNED into b_vflags and call it BV_SCANNED. > - Create a vop_stdfsync() modeled after spec's sync. > - Replace spec_fsync, msdos_fsync, and hpfs_fsync with the stdfsync and some > fs specific processing. This gives all of these filesystems proper > behavior wrt MNT_WAIT/NOWAIT and the use of the B_SCANNED flag. > - Annotate the locking in buf.h I forgot to mention. I tested this with specfs and msdosfs but I do not have access to hpfs. I suspect that it is ok. I will replace ext2s version soon too. Just in case you're wondering.. I'm going through the tree and verifying that all 'struct buf' consumers hold the buf lock. I'm close to completion. I have some scary stuff in nfs, softupdates, and vfs_cluster to sort out still. It's close though. Cheers, Jeff To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-src" in the body of the message