From owner-svn-src-head@FreeBSD.ORG Wed May 15 05:40:02 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 7A20565A; Wed, 15 May 2013 05:40:02 +0000 (UTC) (envelope-from ache@freebsd.org) Received: from mail1.ozon.ru (mx4.ozon.ru [194.186.179.140]) by mx1.freebsd.org (Postfix) with ESMTP id CE84FE98; Wed, 15 May 2013 05:40:01 +0000 (UTC) Received: from intmail03msk.ozon (intmail03msk.ozon [10.18.18.171]) by mail1.ozon.ru (Postfix) with ESMTP id 1EE2771A619; Wed, 15 May 2013 09:40:01 +0400 (MSK) Received: from mail pickup service by intmail03msk.ozon with Microsoft SMTPSVC; Wed, 15 May 2013 09:39:45 +0400 Received: from intmail03msk.ozon ([10.18.18.171]) by intmail02msk.ozon with Microsoft SMTPSVC(6.0.3790.4675); Mon, 13 May 2013 01:37:48 +0400 Received: from mail1.ozon.ru ([194.186.179.140]) by intmail03msk.ozon with Microsoft SMTPSVC(6.0.3790.4675); Mon, 13 May 2013 01:37:47 +0400 Received: from localhost (localhost [127.0.0.1]) by mail1.ozon.ru (Postfix) with ESMTP id 31186719891 for ; Mon, 13 May 2013 01:37:48 +0400 (MSK) X-Virus-Scanned: amavisd-new at ozon.ru Received: from mail1.ozon.ru ([127.0.0.1]) by localhost (mx4.ozon.ru [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jRxfGPJZplZ1 for ; Mon, 13 May 2013 01:37:39 +0400 (MSK) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received-SPF: pass (freebsd.org: 8.8.178.116 is authorized to use 'owner-svn-src-all@freebsd.org' in 'mfrom' identity (mechanism 'ip4:8.8.178.116' matched)) receiver=mx4.ozon.ru; identity=mfrom; envelope-from="owner-svn-src-all@freebsd.org"; helo=mx2.freebsd.org; client-ip=8.8.178.116 Received: from mx2.freebsd.org (mx2.FreeBSD.org [8.8.178.116]) by mail1.ozon.ru (Postfix) with ESMTP id 7D0857197CC for ; Mon, 13 May 2013 01:37:39 +0400 (MSK) Received: from hub.freebsd.org (hub.freebsd.org [IPv6:2001:1900:2254:206c::16:88]) by mx2.freebsd.org (Postfix) with ESMTP id DDAC46144; Sun, 12 May 2013 21:37:37 +0000 (UTC) Received: from hub.freebsd.org (hub.freebsd.org [IPv6:2001:1900:2254:206c::16:88]) by hub.freebsd.org (Postfix) with ESMTP id C05FA6B7; Sun, 12 May 2013 21:37:37 +0000 (UTC) (envelope-from owner-svn-src-all@freebsd.org) Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 9F4D3562 for ; Sun, 12 May 2013 21:37:30 +0000 (UTC) (envelope-from mailer-daemon@vniz.net) Received: from mail-la0-x232.google.com (mail-la0-x232.google.com [IPv6:2a00:1450:4010:c03::232]) by mx1.freebsd.org (Postfix) with ESMTP id 27F58D5 for ; Sun, 12 May 2013 21:37:29 +0000 (UTC) Received: by mail-la0-f50.google.com with SMTP id dz20so1625564lab.23 for ; Sun, 12 May 2013 14:37:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:message-id:date:from:user-agent:mime-version:to:cc :subject:references:in-reply-to:openpgp:content-type :content-transfer-encoding:x-gm-message-state; bh=CY7ZcbhBVsGw/J6YtP1zTX5hlBRMPCfAQxh69e+5ykg=; b=j2r/YbPXoy1t1tBeEBqIFeJBAHdUjOK6vdUdl46uwCV1Wc/F7zd2c2JgCVBkXpo4AC 945TvkmvTrMNCI41aHLwFE3LJX4MhLWDjBbWNxNDtU/30zFdWNl3v4h8EOLeAqB3w0D7 j/rQ0D+wAs5aNisVaJ+0kkll3cfOdzIkr6cAbIHtnGrbfJ7JEuy7x7BWykwtRSvd2+Y/ +cK2+Co0Jsoh56bVg+4UB/5cv9BRrPIxAOvxIZIZnu45L5bt5v5B4A3zxueRuqSsO1SZ tweKuZdndLMcKiCYiYQ6MYdTPgjhnUZWdKBf2FTZNs1DrL7dICJoqJVaKQOIQzfCM6U8 050A== X-Received: by 10.112.139.4 with SMTP id qu4mr11398211lbb.37.1368394649061; Sun, 12 May 2013 14:37:29 -0700 (PDT) Received: from [192.168.1.2] ([89.169.163.3]) by mx.google.com with ESMTPSA id y3sm4392654lby.12.2013.05.12.14.37.28 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Sun, 12 May 2013 14:37:28 -0700 (PDT) Message-ID: <51900B97.20406@freebsd.org> Date: Mon, 13 May 2013 01:37:27 +0400 From: Andrey Chernov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130328 Thunderbird/17.0.5 MIME-Version: 1.0 To: Alan Cox Subject: Re: svn commit: r250577 - head/sys/vm References: <201305121650.r4CGoJL0087149@svn.freebsd.org> In-Reply-To: <201305121650.r4CGoJL0087149@svn.freebsd.org> OpenPGP: id=964474DD X-Gm-Message-State: ALoCoQmVotKWxyomOxSYT2u6HXU/QQp3WViNPMMboLECj9JgRL5sIaUZS/ju0lhUqR0/Agfa9OJ9 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: owner-svn-src-all@freebsd.org Sender: owner-svn-src-all@freebsd.org X-OriginalArrivalTime: 12 May 2013 21:37:47.0962 (UTC) FILETIME=[F23551A0:01CE4F58] Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 May 2013 05:40:02 -0000 On 12.05.2013 20:50, Alan Cox wrote: GNU cc errors related to part of diff below: cc1: warnings being treated as errors ./../../vm/vm_page.c: In function 'vm_page_alloc': ./../../vm/vm_page.c:1209: warning: 'mpred' may be used uninitialized in this function *** [vm_page.o] Error code 1 Formally yes, mpred here can be left unitialized. > @@ -1179,7 +1206,7 @@ vm_page_alloc(vm_object_t object, vm_pin > { > struct vnode *vp = NULL; > vm_object_t m_object; > - vm_page_t m; > + vm_page_t m, mpred; > int flags, req_class; > > KASSERT((object != NULL) == ((req & VM_ALLOC_NOOBJ) == 0), > @@ -1195,6 +1222,11 @@ vm_page_alloc(vm_object_t object, vm_pin > if (curproc == pageproc && req_class != VM_ALLOC_INTERRUPT) > req_class = VM_ALLOC_SYSTEM; > > + if (object != NULL) { > + mpred = vm_radix_lookup_le(&object->rtree, pindex); > + KASSERT(mpred == NULL || mpred->pindex != pindex, > + ("vm_page_alloc: pindex already allocated")); > + } > mtx_lock(&vm_page_queue_free_mtx); > if (cnt.v_free_count + cnt.v_cache_count > cnt.v_free_reserved || > (req_class == VM_ALLOC_SYSTEM && > @@ -1225,8 +1257,8 @@ vm_page_alloc(vm_object_t object, vm_pin > return (NULL); > #if VM_NRESERVLEVEL > 0 > } else if (object == NULL || (object->flags & (OBJ_COLORED | > - OBJ_FICTITIOUS)) != OBJ_COLORED || > - (m = vm_reserv_alloc_page(object, pindex)) == NULL) { > + OBJ_FICTITIOUS)) != OBJ_COLORED || (m = > + vm_reserv_alloc_page(object, pindex, mpred)) == NULL) { > #else > } else { > #endif > @@ -1320,7 +1352,7 @@ vm_page_alloc(vm_object_t object, vm_pin > if (object->memattr != VM_MEMATTR_DEFAULT && > (object->flags & OBJ_FICTITIOUS) == 0) > pmap_page_set_memattr(m, object->memattr); > - vm_page_insert(m, object, pindex); > + vm_page_insert_after(m, object, pindex, mpred); > } else > m->pindex = pindex; -- http://ache.vniz.net/ bitcoin:13fGiNutKNHcVSsgtGQ7bQ5kgUKgEQHn7N _______________________________________________ svn-src-all@freebsd.org mailing list http://lists.freebsd.org/mailman/listinfo/svn-src-all To unsubscribe, send any mail to "svn-src-all-unsubscribe@freebsd.org"