From owner-p4-projects@FreeBSD.ORG  Thu Jul 10 13:48:35 2008
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id C481E1065680; Thu, 10 Jul 2008 13:48:34 +0000 (UTC)
Delivered-To: perforce@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 88548106566B
	for <perforce@FreeBSD.org>; Thu, 10 Jul 2008 13:48:34 +0000 (UTC)
	(envelope-from strauss@FreeBSD.org)
Received: from repoman.freebsd.org (repoman.freebsd.org
	[IPv6:2001:4f8:fff6::29])
	by mx1.freebsd.org (Postfix) with ESMTP id 8275B8FC1B
	for <perforce@FreeBSD.org>; Thu, 10 Jul 2008 13:48:34 +0000 (UTC)
	(envelope-from strauss@FreeBSD.org)
Received: from repoman.freebsd.org (localhost [127.0.0.1])
	by repoman.freebsd.org (8.14.1/8.14.1) with ESMTP id m6ADmYXK021671
	for <perforce@FreeBSD.org>; Thu, 10 Jul 2008 13:48:34 GMT
	(envelope-from strauss@FreeBSD.org)
Received: (from perforce@localhost)
	by repoman.freebsd.org (8.14.2/8.14.1/Submit) id m6ADmY6o021669
	for perforce@freebsd.org; Thu, 10 Jul 2008 13:48:34 GMT
	(envelope-from strauss@FreeBSD.org)
Date: Thu, 10 Jul 2008 13:48:34 GMT
Message-Id: <200807101348.m6ADmY6o021669@repoman.freebsd.org>
X-Authentication-Warning: repoman.freebsd.org: perforce set sender to
	strauss@FreeBSD.org using -f
From: Anselm Strauss <strauss@FreeBSD.org>
To: Perforce Change Reviews <perforce@FreeBSD.org>
Cc: 
Subject: PERFORCE change 145018 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 10 Jul 2008 13:48:35 -0000

http://perforce.freebsd.org/chv.cgi?CH=145018

Change 145018 by strauss@strauss_marvelman on 2008/07/10 13:47:51

	- sizeof/strlen fix
	- Enabled all compiler warnings globally

Affected files ...

.. //depot/projects/soc2008/strauss_libarchive/Makefile.am#6 edit
.. //depot/projects/soc2008/strauss_libarchive/TODO#9 edit
.. //depot/projects/soc2008/strauss_libarchive/libarchive/archive_write_set_format_zip.c#8 edit

Differences ...

==== //depot/projects/soc2008/strauss_libarchive/Makefile.am#6 (text+ko) ====

@@ -429,3 +429,5 @@
 	cpio/test/test_option_t.cpio.uu		\
 	cpio/test/test_option_t.stdout.uu	\
 	cpio/test/test_option_tv.stdout.uu
+
+AM_CFLAGS="-Wall"

==== //depot/projects/soc2008/strauss_libarchive/TODO#9 (text+ko) ====

@@ -1,7 +1,6 @@
 To Be Done
 ==========
 
-- How to enable '-Wall' in gcc when calling make?
 - Exception handling in ZIP writer
 - Update ZIP writer in docs
 - Integrate Libarchive 2.5.5
@@ -12,6 +11,7 @@
 Already Done
 ============
 
+- How to enable '-Wall' in gcc when calling make? -> Use 'make CFLAGS="-Wall" ...'
 - Update ZIP writer in headers
 - Build does not work outside source dir
 - Enable P4 keyword expansion and adapt all source files

==== //depot/projects/soc2008/strauss_libarchive/libarchive/archive_write_set_format_zip.c#8 (text+ko) ====

@@ -165,7 +165,7 @@
 	/* Write filename and extra field (extra field is currently null).
 	 * These are not included in the header structure due to variable size. */
 	const char *path = archive_entry_pathname(entry);
-	ret = (a->compressor.write)(a, path, sizeof(*path));
+	ret = (a->compressor.write)(a, path, strlen(path));
 	if (ret != ARCHIVE_OK)
 		return (ARCHIVE_FATAL);