From owner-cvs-all@FreeBSD.ORG  Tue Jan 20 20:54:22 2004
Return-Path: <owner-cvs-all@FreeBSD.ORG>
Delivered-To: cvs-all@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 8BFD716A4CE; Tue, 20 Jan 2004 20:54:22 -0800 (PST)
Received: from gw.catspoiler.org (217-ip-163.nccn.net [209.79.217.163])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 59F4043D41; Tue, 20 Jan 2004 20:54:21 -0800 (PST)
	(envelope-from truckman@FreeBSD.org)
Received: from FreeBSD.org (mousie.catspoiler.org [192.168.101.2])
	by gw.catspoiler.org (8.12.9p2/8.12.9) with ESMTP id i0L4sA7E060634;
	Tue, 20 Jan 2004 20:54:14 -0800 (PST)
	(envelope-from truckman@FreeBSD.org)
Message-Id: <200401210454.i0L4sA7E060634@gw.catspoiler.org>
Date: Tue, 20 Jan 2004 20:54:10 -0800 (PST)
From: Don Lewis <truckman@FreeBSD.org>
To: bde@zeta.org.au
In-Reply-To: <20040120175334.W3279@gamplex.bde.org>
MIME-Version: 1.0
Content-Type: TEXT/plain; charset=us-ascii
cc: cvs-src@FreeBSD.org
cc: src-committers@FreeBSD.org
cc: phk@FreeBSD.org
cc: cvs-all@FreeBSD.org
Subject: Re: cvs commit: src/sys/alpha/alpha support.s src/sys/i386/i386   
 swtch.s src/sys/kern kern_shutdown.c src/sys/sys systm.h
X-BeenThere: cvs-all@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: CVS commit messages for the entire tree <cvs-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-all>
List-Post: <mailto:cvs-all@freebsd.org>
List-Help: <mailto:cvs-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-all>,
	<mailto:cvs-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 21 Jan 2004 04:54:22 -0000

On 20 Jan, Bruce Evans wrote:
> On Mon, 19 Jan 2004, Poul-Henning Kamp wrote:
> 
>> phk         2004/01/19 13:27:11 PST
>>
>>   FreeBSD src repository
>>
>>   Modified files:
>>     sys/alpha/alpha      support.s
>>     sys/i386/i386        swtch.s
>>     sys/kern             kern_shutdown.c
>>     sys/sys              systm.h
>>   Log:
>>   Add linenumber and source filename to panic(9) output.
> 
> This was rejected in all reviews.  It gives less information than
> grepping the sources, at some cost (grep at least gives correct line
> numbers when the sources don't quite match the binary).

One point in favor of including the file name is that it allows the
consumer of this information to grep the correct file instead of having
to grep all of /usr/src/sys.  The line number is pretty useless, though.

What about the case of macros like KASSERT() and the vnode lock
assertions?  Won't they report the name and line number of the #define?