From owner-svn-ports-head@FreeBSD.ORG Tue Mar 12 11:18:04 2013 Return-Path: Delivered-To: svn-ports-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by hub.freebsd.org (Postfix) with ESMTP id 054D1323; Tue, 12 Mar 2013 11:18:04 +0000 (UTC) (envelope-from makc@freebsd.org) Received: from mail.issp.ac.ru (mail.issp.ac.ru [77.236.34.3]) by mx1.freebsd.org (Postfix) with ESMTP id 84719D77; Tue, 12 Mar 2013 11:18:03 +0000 (UTC) Received: from mercury.ph.man.ac.uk [130.88.75.175:28787] (HELO/EHLO mercury.ph.man.ac.uk, authenticated with LOGIN) by mail.issp.ac.ru with ESMTP/inet id r2CBHuuS016645 (using TLSv1/SSLv3, with cipher DHE-RSA-AES256-SHA (256 bits), verified NO) Tue, 12 Mar 2013 15:17:56 +0400 (MSK) From: Max Brazhnikov To: Alexey Dokuchaev Subject: Re: svn commit: r313841 - head/comms/openobex Date: Tue, 12 Mar 2013 11:18:59 +0000 Message-ID: <1886726.vG9fsaSg1C@mercury.ph.man.ac.uk> User-Agent: KMail/4.9.5 (FreeBSD/9.1-STABLE; KDE/4.10.1; amd64; ; ) In-Reply-To: <20130312014941.GC92762@FreeBSD.org> References: <201303102105.r2AL5C2o048218@svn.freebsd.org> <513E5682.1070704@FreeBSD.org> <20130312014941.GC92762@FreeBSD.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="koi8-r" Cc: svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, Guido Falsi , ports-committers@freebsd.org X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Mar 2013 11:18:04 -0000 On Tue, 12 Mar 2013 01:49:41 +0000 Alexey Dokuchaev wrote: > On Mon, Mar 11, 2013 at 11:11:14PM +0100, Guido Falsi wrote: > > >>Would it be feasible to make DOXYGEN default for bulk pacakge building > > >>cases but not for regular port users (that is, hide it behind BATCH or > > >>PACKAGE_BUILDING)? > > > > I do like your idea. > > > > I have tested the port with the following stanza after OPTIONS_DEFINE: > > > > .if !defined(BATCH) && !defined(PACKAGE_BUILDING) > > OPTIONS_DEFAULT+= DOXYGEN > > .endif > > > > It does work as expected, is this what you had in mind? > > Yes, exactly. > > > Should I check only against one of the two variables? > > Not sure; better ask someone who's closer to package builder cluster? :) Tinderbox sets both PACKAGE_BUILDING and BATCH, same does the pointyhat if I'm not mistaken. In this case the check for PACKAGE_BUILDING is enough. But I'd really like to see port-wide implementation. I'm willing to make one, just need some time to finish new KDE ports. Max