From owner-freebsd-ports-bugs@FreeBSD.ORG Wed Jun 23 22:41:00 2004 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 9E98916A4CE for ; Wed, 23 Jun 2004 22:41:00 +0000 (GMT) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 7909843D4C for ; Wed, 23 Jun 2004 22:41:00 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) i5NMeHPs010646 for ; Wed, 23 Jun 2004 22:40:17 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.12.11/8.12.11/Submit) id i5NMeHFL010645; Wed, 23 Jun 2004 22:40:17 GMT (envelope-from gnats) Resent-Date: Wed, 23 Jun 2004 22:40:17 GMT Resent-Message-Id: <200406232240.i5NMeHFL010645@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Jean-Yves Lefort Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4F3C916A4CE for ; Wed, 23 Jun 2004 22:39:43 +0000 (GMT) Received: from gateway.lefort.net (212.68.242.203.brutele.be [212.68.242.203]) by mx1.FreeBSD.org (Postfix) with ESMTP id ADD0D43D3F for ; Wed, 23 Jun 2004 22:39:42 +0000 (GMT) (envelope-from jylefort@brutele.be) Received: from jsite.lefort.net (jsite.lefort.net [192.168.1.2]) by gateway.lefort.net (Postfix) with ESMTP id 5E1B654C7 for ; Thu, 24 Jun 2004 00:39:33 +0200 (CEST) Received: by jsite.lefort.net (Postfix, from userid 1000) id 084D522E28; Thu, 24 Jun 2004 00:39:33 +0200 (CEST) Message-Id: <20040623223933.084D522E28@jsite.lefort.net> Date: Thu, 24 Jun 2004 00:39:33 +0200 (CEST) From: Jean-Yves Lefort To: FreeBSD-gnats-submit@FreeBSD.org X-Send-Pr-Version: 3.113 Subject: ports/68256: bsd.gnome.mk locale patch is incomplete X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: Jean-Yves Lefort List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 23 Jun 2004 22:41:00 -0000 >Number: 68256 >Category: ports >Synopsis: bsd.gnome.mk locale patch is incomplete >Confidential: no >Severity: non-critical >Priority: medium >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: change-request >Submitter-Id: current-users >Arrival-Date: Wed Jun 23 22:40:17 GMT 2004 >Closed-Date: >Last-Modified: >Originator: Jean-Yves Lefort >Release: FreeBSD 4.10-RELEASE i386 >Organization: >Environment: System: FreeBSD jsite.lefort.net 4.10-RELEASE FreeBSD 4.10-RELEASE #0: Thu May 27 14:42:30 CEST 2004 jylefort@jsite.lefort.net:/usr/obj/usr/src/sys/JSITE i386 >Description: The gnomehack component of bsd.gnome.mk fixes the locale path in the Makefile.in files. However, for most programs the locale path also needs to be patched in the configure scripts, since it's the place from where the path is hardwired into the program. Failing to do so results in a program trying to find its translations in the wrong location, and the problem is likely to stay unnoticed. The attached patch fixes the issue. WARNING: some ports already fix that themselves by the mean of a configure patch. These ports will break if this patch is committed, therefore I suggest to mail the maintainers of all the ports using USE_GNOME=gnomehack and having a configure patch, asking them to fix their port(s). >How-To-Repeat: >Fix: --- bsd.gnome.mk.orig Thu Jun 24 00:02:27 2004 +++ bsd.gnome.mk Thu Jun 24 00:02:34 2004 @@ -59,7 +59,9 @@ s|[(]libdir[)]/bonobo/servers|(prefix)/libdata/bonobo/servers|g' ; \ ${FIND} ${WRKSRC} -name "configure" | ${XARGS} ${REINPLACE_CMD} -e \ 's|-lpthread|${PTHREAD_LIBS}|g ; \ - s|DATADIRNAME=lib|DATADIRNAME=share|g' + s|DATADIRNAME=lib|DATADIRNAME=share|g ; \ + s|{datadir}/locale|{prefix}/share/locale|g ; \ + s|{libdir}/locale|{prefix}/share/locale|g' lthack_PRE_PATCH= ${FIND} ${WRKSRC} -name "configure" | ${XARGS} ${REINPLACE_CMD} -e \ '/^LIBTOOL_DEPS="$$ac_aux_dir\/ltmain.sh"$$/s|$$|; $$ac_aux_dir/ltconfig $$LIBTOOL_DEPS;|' >Release-Note: >Audit-Trail: >Unformatted: