From owner-svn-src-all@FreeBSD.ORG  Thu Dec 22 18:27:09 2011
Return-Path: <owner-svn-src-all@FreeBSD.ORG>
Delivered-To: svn-src-all@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id DDDCA106566B;
	Thu, 22 Dec 2011 18:27:09 +0000 (UTC) (envelope-from des@des.no)
Received: from smtp.des.no (smtp.des.no [194.63.250.102])
	by mx1.freebsd.org (Postfix) with ESMTP id F3DB98FC08;
	Thu, 22 Dec 2011 18:27:08 +0000 (UTC)
Received: from ds4.des.no (des.no [84.49.246.2])
	by smtp.des.no (Postfix) with ESMTP id 984696DE1;
	Thu, 22 Dec 2011 18:27:05 +0000 (UTC)
Received: by ds4.des.no (Postfix, from userid 1001)
	id 57C8F81BB; Thu, 22 Dec 2011 19:27:05 +0100 (CET)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Gleb Smirnoff <glebius@FreeBSD.org>
References: <201112221810.pBMIAFlo028054@svn.freebsd.org>
	<20111222182219.GS80057@FreeBSD.org>
Date: Thu, 22 Dec 2011 19:27:05 +0100
In-Reply-To: <20111222182219.GS80057@FreeBSD.org> (Gleb Smirnoff's message of
	"Thu, 22 Dec 2011 22:22:19 +0400")
Message-ID: <86bor0sbra.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: svn-src-all@FreeBSD.org, src-committers@FreeBSD.org,
	svn-src-vendor@FreeBSD.org
Subject: Re: svn commit: r228809 - vendor/openpam/dist/lib
X-BeenThere: svn-src-all@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: "SVN commit messages for the entire src tree \(except for &quot;
	user&quot; and &quot; projects&quot; \)" <svn-src-all.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all>
List-Post: <mailto:svn-src-all@freebsd.org>
List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-all>,
	<mailto:svn-src-all-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 22 Dec 2011 18:27:10 -0000

Gleb Smirnoff <glebius@FreeBSD.org> writes:
> I haven't yet tested this, but code looks like it is not going to print
> anything in a case I don't have /usr/local/bin/pam_foo.so, while purpose
> of the patch is to avoid logging of failure to open
> /usr/local/bin/pam_foo.so.5.
>
> Although openpam_dynamic() will do some logging of errno value, the name
> of the failed file won't be logged. If I got a lot of modules configured,
> then I can't figure out which one is ENOENT.
>
> IMHO, some no_log flag should be passed down from the try_dlopen() to fix
> the issue correctly.

Index: openpam_dynamic.c
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- openpam_dynamic.c   (revision 509)
+++ openpam_dynamic.c   (working copy)
@@ -124,7 +124,7 @@
          dlclose(dlh);
          FREE(module);
 err:
-       openpam_log(PAM_LOG_ERROR, "%m");
+       openpam_log(PAM_LOG_ERROR, "%s: %m", path);
        return (NULL);
 }
=20

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no