From owner-freebsd-current Mon Apr 22 12:59:42 2002 Delivered-To: freebsd-current@freebsd.org Received: from mailman.zeta.org.au (mailman.zeta.org.au [203.26.10.16]) by hub.freebsd.org (Postfix) with ESMTP id 87FD037B42A; Mon, 22 Apr 2002 12:59:17 -0700 (PDT) Received: from bde.zeta.org.au (bde.zeta.org.au [203.2.228.102]) by mailman.zeta.org.au (8.9.3/8.8.7) with ESMTP id XAA18343; Mon, 22 Apr 2002 23:19:49 +1000 Date: Mon, 22 Apr 2002 23:20:42 +1000 (EST) From: Bruce Evans X-X-Sender: bde@gamplex.bde.org To: "Jacques A. Vidrine" Cc: alfred@FreeBSD.org, , Maxim Konovalov , , Adrian Penisoara Subject: Re: panic:bremfree with today's current and linux-netscape In-Reply-To: <20020422120247.GD68403@madman.nectar.cc> Message-ID: <20020422231049.V8742-100000@gamplex.bde.org> MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Mon, 22 Apr 2002, Jacques A. Vidrine wrote: > On Mon, Apr 22, 2002 at 06:25:17PM +1000, Bruce Evans wrote: > > I use the same patch. Locking here is essentially equivalent to calling > > panic() here (except it gives a more confusing panic message :-). > > :-) That's a bit of an overstatement; my testing didn't catch it. I Yes; I forgot to write the clause about it only being equivalent to a panic if certain options (mainly INVARIANTS) are configured. > do see that falloc does lock the file descriptor table too, though --- > I wonder how it ever worked. INVARIANTS causes a check of an assertion that non-recursive locks like fd_mtx aren't actually misused recursively. The check causes more panics than the misuse since the misuse is rarely fatal. I may be missing something since I rarely use INVARIANTS and haven't checked that it causes the panic deterministically. Bruce To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message