From owner-freebsd-bugs@FreeBSD.ORG  Wed May 29 18:40:00 2013
Return-Path: <owner-freebsd-bugs@FreeBSD.ORG>
Delivered-To: freebsd-bugs@smarthost.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id BAAB2375
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Wed, 29 May 2013 18:40:00 +0000 (UTC)
 (envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org
 [IPv6:2001:1900:2254:206c::16:87])
 by mx1.freebsd.org (Postfix) with ESMTP id 8875AFC2
 for <freebsd-bugs@smarthost.ysv.freebsd.org>;
 Wed, 29 May 2013 18:40:00 +0000 (UTC)
Received: from freefall.freebsd.org (localhost [127.0.0.1])
 by freefall.freebsd.org (8.14.7/8.14.7) with ESMTP id r4TIe0wf002449
 for <freebsd-bugs@freefall.freebsd.org>; Wed, 29 May 2013 18:40:00 GMT
 (envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
 by freefall.freebsd.org (8.14.7/8.14.7/Submit) id r4TIe0X7002448;
 Wed, 29 May 2013 18:40:00 GMT (envelope-from gnats)
Resent-Date: Wed, 29 May 2013 18:40:00 GMT
Resent-Message-Id: <201305291840.r4TIe0X7002448@freefall.freebsd.org>
Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer)
Resent-To: freebsd-bugs@FreeBSD.org
Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org,
 hardik mehta <rometoroam@gmail.com>
Received: from mx1.freebsd.org (mx1.FreeBSD.org [8.8.178.115])
 by hub.freebsd.org (Postfix) with ESMTP id CB6141C9
 for <freebsd-gnats-submit@FreeBSD.org>; Wed, 29 May 2013 18:32:13 +0000 (UTC)
 (envelope-from nobody@FreeBSD.org)
Received: from oldred.FreeBSD.org (oldred.freebsd.org [8.8.178.121])
 by mx1.freebsd.org (Postfix) with ESMTP id BEA27F5B
 for <freebsd-gnats-submit@FreeBSD.org>; Wed, 29 May 2013 18:32:13 +0000 (UTC)
Received: from oldred.FreeBSD.org ([127.0.1.6])
 by oldred.FreeBSD.org (8.14.5/8.14.5) with ESMTP id r4TIWDBt008128
 for <freebsd-gnats-submit@FreeBSD.org>; Wed, 29 May 2013 18:32:13 GMT
 (envelope-from nobody@oldred.FreeBSD.org)
Received: (from nobody@localhost)
 by oldred.FreeBSD.org (8.14.5/8.14.5/Submit) id r4TIWDiv008127;
 Wed, 29 May 2013 18:32:13 GMT (envelope-from nobody)
Message-Id: <201305291832.r4TIWDiv008127@oldred.FreeBSD.org>
Date: Wed, 29 May 2013 18:32:13 GMT
From: hardik mehta <rometoroam@gmail.com>
To: freebsd-gnats-submit@FreeBSD.org
X-Send-Pr-Version: www-3.1
Subject: misc/179083: Invalid index calucation in netmap macro expansion 
X-BeenThere: freebsd-bugs@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: Bug reports <freebsd-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-bugs>
List-Post: <mailto:freebsd-bugs@freebsd.org>
List-Help: <mailto:freebsd-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-bugs>,
 <mailto:freebsd-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 29 May 2013 18:40:00 -0000


>Number:         179083
>Category:       misc
>Synopsis:       Invalid index calucation in netmap macro expansion
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Wed May 29 18:40:00 UTC 2013
>Closed-Date:
>Last-Modified:
>Originator:     hardik mehta
>Release:        9.1
>Organization:
nik
>Environment:
FreeBSD pcthw21 9.1-RELEASE FreeBSD 9.1-RELEASE
[hmehta@pcthw21 ~]$ sysctl kern.osreldate
kern.osreldate: 901000
>Description:

#define NETMAP_BUF(ring, index)				\
	((char *)(ring) + (ring)->buf_ofs + ((index)*(ring)->nr_buf_size))

In this macro index passed on should be the same as buf_idx from slot structure pointed by ring->cur. As shown in example code instead of using buf_idx pointed of slot structure pointed by ring->cur it uses direct index. Macro should be then expanded as 
#define NETMAP_BUF(ring, index)				\
	((char *)(ring) + (ring)->buf_ofs + ((ring)->slot[index].buf_idx*(ring)->nr_buf_size))
>How-To-Repeat:

>Fix:
define 
#define NETMAP_BUF(ring, index)				\
	((char *)(ring) + (ring)->buf_ofs + ((ring)->slot[index].buf_idx*(ring)->nr_buf_size))

>Release-Note:
>Audit-Trail:
>Unformatted: