From owner-p4-projects@FreeBSD.ORG  Tue Jan  3 20:44:55 2012
Return-Path: <owner-p4-projects@FreeBSD.ORG>
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id ACAC31065675; Tue,  3 Jan 2012 20:44:55 +0000 (UTC)
Delivered-To: perforce@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 6F6A91065670
	for <perforce@freebsd.org>; Tue,  3 Jan 2012 20:44:55 +0000 (UTC)
	(envelope-from pjd@freebsd.org)
Received: from skunkworks.freebsd.org (skunkworks.freebsd.org
	[IPv6:2001:4f8:fff6::2d])
	by mx1.freebsd.org (Postfix) with ESMTP id 5CD928FC08
	for <perforce@freebsd.org>; Tue,  3 Jan 2012 20:44:55 +0000 (UTC)
Received: from skunkworks.freebsd.org (localhost [127.0.0.1])
	by skunkworks.freebsd.org (8.14.4/8.14.4) with ESMTP id q03KitDe052860
	for <perforce@freebsd.org>; Tue, 3 Jan 2012 20:44:55 GMT
	(envelope-from pjd@freebsd.org)
Received: (from perforce@localhost)
	by skunkworks.freebsd.org (8.14.4/8.14.4/Submit) id q03KitsZ052857
	for perforce@freebsd.org; Tue, 3 Jan 2012 20:44:55 GMT
	(envelope-from pjd@freebsd.org)
Date: Tue, 3 Jan 2012 20:44:55 GMT
Message-Id: <201201032044.q03KitsZ052857@skunkworks.freebsd.org>
X-Authentication-Warning: skunkworks.freebsd.org: perforce set sender to
	pjd@freebsd.org using -f
From: Pawel Jakub Dawidek <pjd@FreeBSD.org>
To: Perforce Change Reviews <perforce@freebsd.org>
Precedence: bulk
Cc: 
Subject: PERFORCE change 203939 for review
X-BeenThere: p4-projects@freebsd.org
X-Mailman-Version: 2.1.5
List-Id: p4 projects tree changes <p4-projects.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/p4-projects>
List-Post: <mailto:p4-projects@freebsd.org>
List-Help: <mailto:p4-projects-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/p4-projects>,
	<mailto:p4-projects-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Jan 2012 20:44:55 -0000

http://p4web.freebsd.org/@@203939?ac=10

Change 203939 by pjd@pjd_anger on 2012/01/03 20:44:37

	Remove impossible condition. If we are here, the error variable
	must be 0, so no need to check it.

Affected files ...

.. //depot/projects/trustedbsd/openbsm/libauditd/auditd_lib.c#16 edit

Differences ...

==== //depot/projects/trustedbsd/openbsm/libauditd/auditd_lib.c#16 (text+ko) ====

@@ -26,7 +26,7 @@
  * IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
  * POSSIBILITY OF SUCH DAMAGE.
  *
- * $P4: //depot/projects/trustedbsd/openbsm/libauditd/auditd_lib.c#15 $
+ * $P4: //depot/projects/trustedbsd/openbsm/libauditd/auditd_lib.c#16 $
  */
 
 #include <sys/param.h>
@@ -852,8 +852,6 @@
                                 /* Success. */
                                 *newfile = fn;
                                 close(fd);
-				if (error)
-					return (error);
 				if (saverrno) {
 					/*
 					 * auditctl() failed but still