From owner-freebsd-current@FreeBSD.ORG  Mon Oct 19 11:48:57 2009
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: current@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 0B4041065670
	for <current@freebsd.org>; Mon, 19 Oct 2009 11:48:57 +0000 (UTC)
	(envelope-from des@des.no)
Received: from tim.des.no (tim.des.no [194.63.250.121])
	by mx1.freebsd.org (Postfix) with ESMTP id BF3528FC17
	for <current@freebsd.org>; Mon, 19 Oct 2009 11:48:55 +0000 (UTC)
Received: from ds4.des.no (des.no [84.49.246.2])
	by smtp.des.no (Postfix) with ESMTP id D96056D41C;
	Mon, 19 Oct 2009 11:48:54 +0000 (UTC)
Received: by ds4.des.no (Postfix, from userid 1001)
	id 7BF5F844CC; Mon, 19 Oct 2009 13:48:54 +0200 (CEST)
From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@des.no>
To: Kostik Belousov <kostikbel@gmail.com>
References: <alpine.BSF.2.00.0910171503010.89326@wonkity.com>
	<alpine.BSF.2.00.0910181542440.94243@wonkity.com>
	<20091018220935.GR2160@deviant.kiev.zoral.com.ua>
	<86my3n6d8k.fsf@ds4.des.no>
	<20091019112938.GT2160@deviant.kiev.zoral.com.ua>
Date: Mon, 19 Oct 2009 13:48:54 +0200
In-Reply-To: <20091019112938.GT2160@deviant.kiev.zoral.com.ua> (Kostik
	Belousov's message of "Mon, 19 Oct 2009 14:29:38 +0300")
Message-ID: <86iqeb61uh.fsf@ds4.des.no>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.95 (berkeley-unix)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Cc: Warren Block <wblock@wonkity.com>, current@freebsd.org
Subject: Re: /etc/rc.d locking devd.pid
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>, 
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 19 Oct 2009 11:48:57 -0000

Kostik Belousov <kostikbel@gmail.com> writes:
> Why ? We definitely leak file descriptor on exec(2) unless daemon
> explicitely closes it after fork. I said that it is unobvious is it
> right to enforce FD_CLOEXEC unconditionally, because some daemons
> exec() itself to reinitialize.

Sorry, you're right, FD_CLOEXEC does not affect fork(2).

Anyway - I'm writing regression tests for pidfile(3).  Please don't
commit anything until they're done.

DES
--=20
Dag-Erling Sm=C3=B8rgrav - des@des.no